Re-organizing templates #1793
Merged
Re-organizing templates #1793
+59,502
−456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erwinvandervalk
added
impact/breaking
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
2 times, most recently
from
bb83972 to
071edfa
Compare
Erwinvandervalk
requested review from
josephdecock and
bhazen
as code owners
damianh
reviewed
Feb 13, 2025
damianh
reviewed
Feb 13, 2025
damianh
reviewed
Feb 13, 2025
damianh
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Looks good modern and arrangement wise. Few things
- The template readmes need updating. The IS one shouldn't mention BFF and vice versa. Title, and instructuctions with the new package names.
- the
build.ps1,nuget.configandglobal.jsoncould probably be removed?
damianh
approved these changes
Feb 13, 2025
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
4 times, most recently
from
3e66ceb to
2f13a57
Compare
josephdecock
requested changes
Feb 15, 2025
identity-server/templates/templates/IdentityServerAspNetIdentity/.template.config/template.json
Outdated
Show resolved
Hide resolved
|
We should also look into creating a meta package that depends on all the product specific template packages. We could have that be the next version of the existing package. The goal is to
|
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
from
2f13a57 to
769f73f
Compare
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
from
52959bd to
c51c270
Compare
josephdecock
approved these changes
Feb 18, 2025
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
2 times, most recently
from
13af0f2 to
766533e
Compare
Erwinvandervalk
force-pushed
the
ev/templates/revamp
branch
from
766533e to
f548865
Compare
|
The codeql build failures are not caused by this PR, so i'm merging it despite these being 'red'. This PR is getting too big to keep rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Reorganizes how we handle templates.
Breaking changes
This PR deprecates the Duende.IdentityServer.Templates in favor of Duende.Templates.IdentityServer and Duende.Templates.BFF.
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)