Feat login id validation

[Gopal-001]

**My PR closes #716 **

👨‍💻 Changes proposed(What did you do ?)

during the merging process the condition got refactored causing breaking of login part.
redo the condition.

  if (!id && (typeof id !== 'string' || !userIDPattern.test(id))) {

here if email login than id will be undefined so condition so we are checking if id is coming than moving fwd to verify the type and regex pattern, and if it's invalid we'll just move ahead.

✔️ Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• This PR does not contain plagiarized content.
• The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

NA

[vercel]

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

• docs: correct typo in README
• feat: implement dark mode"
• fix: correct remove button behavior

Linting Errors

• Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
• No subject found

[Dun-sin]

@Gopal-001 think it fails because your solution wasn't reviewed properly by me, but not because of that code specifically.

but because you were trying to validate the ID, your code is wrong and my refactor was what was needed, you didn't test this in local, please do next time

but yeah will fix it on my end and push it, will share the commit if you would like to see the solution

[Dun-sin]

@Gopal-001 actually you were right, will fix it to match both cases and still not allow a pass

[Dun-sin]

@Gopal-001 had to revert to the old code in server, but kept the one in frontend. Thanks

[Gopal-001]

@Gopal-001 think it fails because your solution wasn't reviewed properly by me, but not because of that code specifically.

but because you were trying to validate the ID, your code is wrong and my refactor was what was needed, you didn't test this in local, please do next time

but yeah will fix it on my end and push it, will share the commit if you would like to see the solution

@Dun-sin sure thanks for the feedback, although I've already teseted it but if you're looking into it.However pls refer to this commit 308b606 if in page server/utils/helper.js we just replace this condition back if(!id && (typeof id !== 'string' || !userIDPattern.test(id))) it will work properly.

[Dun-sin]

@Gopal-001 think it fails because your solution wasn't reviewed properly by me, but not because of that code specifically.

but because you were trying to validate the ID, your code is wrong and my refactor was what was needed, you didn't test this in local, please do next time

but yeah will fix it on my end and push it, will share the commit if you would like to see the solution

@Dun-sin sure thanks for the feedback, although I've already teseted it but if you're looking into it.However pls refer to this commit 308b606 if in page server/utils/helper.js we just replace this condition back if(!id && (typeof id !== 'string' || !userIDPattern.test(id))) it will work properly.

It works but it's not an ideal solution