feat: add back button and anonymous login warning (#720) #738
Conversation
|
@sant0143 is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sant0143
changed the title
sant0143
changed the title
client/src/pages/Home.jsx
Outdated
| <img | ||
| src="/landing page image.jpg" | ||
| alt="Landing page illustration" | ||
| className="h-auto rounded-full w-auto object-cover" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
| {showAnonymousConfirm && ( | ||
| <div className="fixed inset-0 bg-black bg-opacity-50 flex items-center justify-center"> | ||
| <div className="bg-white dark:bg-gray-800 p-6 rounded-lg shadow-xl max-w-md w-full"> | ||
| <h2 className="text-2xl font-bold mb-4 text-gray-900 dark:text-white"> | ||
| Login Anonymously | ||
| </h2> | ||
| <p className="mb-6 text-gray-700 dark:text-gray-300"> | ||
| Are you sure you want to login anonymously? This will create a temporary account. | ||
| </p> | ||
| <div className="flex justify-end space-x-4"> | ||
| <button | ||
| onClick={() => setShowAnonymousConfirm(false)} | ||
| className="px-4 py-2 text-sm font-medium text-gray-700 bg-gray-200 rounded-md hover:bg-gray-300 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-gray-500" | ||
| > |
There was a problem hiding this comment.
@sant0143 we already have a dialog modal you can use, please use that instead
https://github.com/Dun-sin/Whisper/blob/main/client/src/components/Dialog.jsx
|
Added the default dialog please check @Dun-sin |
|
Hello @Dun-sin i have made requested changes and raised the PR |
There was a problem hiding this comment.
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
yes sure @Dun-sin will be happy to contribute to this project in future |
|
@sant0143 on testing, the dialog doesn't work, you can check the preview with the vercel comment |
|
@sant0143 and can we have a back button where the arrow is pointing to instead |
|
i have asked for approval please give approval will check it |
the vercel link is the updated code |
can u provide the link here? |
|
@sant0143 i checked the latest link and the changes haven't been made |
|
@sant0143 is this something you are still interested in working on? |
Fixes Issue
**My PR closes #720 **
👨💻 Changes proposed(What did you do ?)
✔️ Check List (Check all the applicable boxes)
Note to reviewers
📷 Screenshots