Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where loading package does not re-execute graph. #4

Merged
merged 6 commits into from
Jan 9, 2024
Merged

fix bug where loading package does not re-execute graph. #4

merged 6 commits into from
Jan 9, 2024

Conversation

mjkkirschner
Copy link
Member

PR does the following:

  • missed some changes that were actually in the package.
  • fix a bug where dynamo previously re executed the graph when this library was imported, but I realized we don't actually need or want to import these types into the library, so just re execute the graph - this fixes the bug @avidit found.

@mjkkirschner mjkkirschner merged commit c0caa15 into master Jan 9, 2024
12 checks passed
@mjkkirschner mjkkirschner deleted the isolate branch January 9, 2024 03:58
@mjkkirschner
Copy link
Member Author

merging this as it has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzart90 pinzart90 Awaiting requested review from pinzart90

@avidit avidit Awaiting requested review from avidit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mjkkirschner