add tests #6
Merged
add tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
commented
Jan 30, 2024
mjkkirschner
commented
Jan 30, 2024
mjkkirschner
commented
Jan 30, 2024
|
|
||
|
|
||
| [SetUpFixture] | ||
| public class Setup |
There was a problem hiding this comment.
this code is stolen from @pinzart90's example in DynamoSamples repo.
mjkkirschner
commented
Jan 30, 2024
avidit
reviewed
Jan 30, 2024
pinzart90
reviewed
Jan 30, 2024
pinzart90
reviewed
Jan 30, 2024
pinzart90
reviewed
Jan 30, 2024
pinzart90
reviewed
Jan 30, 2024
| <Nullable>enable</Nullable> | ||
|
|
||
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> |
There was a problem hiding this comment.
IsTestProject is set automatically by consuming the microsoft test.sdk nuget
Not sure why you need to specify IsPackable false
There was a problem hiding this comment.
these were set by VS when creating a test project from nunit template. Do you want me to remove them?
pinzart90
approved these changes
Jan 30, 2024
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="DynamoVisualProgramming.Tests" Version="3.1.0-beta3874" /> |
There was a problem hiding this comment.
Curious why the DynamoCoreRuntime used is 3.0.2 whereas the references are 3.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test project
pull dynamo core from s3 and run tests.
move to net8