for default use cases avoid having extra binaries from MLC dep. (#15170)

for now I will merge this - if we decide to exclude copying these dep binaries from for all targets it's easy to do.
DynamoDS · Apr 24, 2024 · 210ed3b · 210ed3b
1 parent 1aff855
commit 210ed3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/NodeServices/DynamoServices.csproj b/src/NodeServices/DynamoServices.csproj
@@ -17,6 +17,7 @@
     <NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" />
+      <!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8 runtime.-->
+    <PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
   </ItemGroup>
 </Project>
diff --git a/tools/NuGet/template-nuget/DynamoVisualProgramming.DynamoServices.nuspec b/tools/NuGet/template-nuget/DynamoVisualProgramming.DynamoServices.nuspec
@@ -15,7 +15,13 @@
         It also contains useful static events and event data for monitoring workspace and execution changes.</summary>
         <copyright>Copyright Autodesk 2023</copyright>
         <dependencies>
-            <group targetFramework="netstandard2.0" />
+            <group targetFramework="netstandard2.0">
+                <dependency id="System.Reflection.MetadataLoadContext" version="8.0.0" />
+            </group>
+            <!--when targeting .net8 metadataloadcontext's transitive deps can be loaded from the runtime-->
+            <group targetFramework="net8.0">
+                <dependency id="System.Reflection.MetadataLoadContext" version="8.0.0" exclude="build,analyzers,runtime" />
+            </group>
         </dependencies>
     </metadata>
     <files>