DYN-7206: Improve list of selected ids when long (#15366)

DynamoDS · Aug 19, 2024 · 4426ba4 · 4426ba4
1 parent 5dc7213
commit 4426ba4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/Libraries/CoreNodeModels/Selection.cs b/src/Libraries/CoreNodeModels/Selection.cs
@@ -198,7 +198,7 @@ protected SelectionBase(
         public override string ToString()
         {
             return SelectionResults.Any()
-                ? string.Format("{0} : {1}", Prefix, FormatSelectionText(SelectionResults))
+                ? string.Format("{0}: {1}", Prefix, FormatSelectionText(SelectionResults))
                 : Resources.SelectionNodeNothingSelected;
         }
 
@@ -236,9 +236,19 @@ public bool CanBeginSelect()
 
         protected virtual string FormatSelectionText<T>(IEnumerable<T> elements)
         {
-            return elements.Any()
-                ? System.String.Join(" ", SelectionResults.Take(20).Select(x=>x.ToString()))
-                : "";
+            if (elements.Any())
+            {
+                string text = string.Join(", ", elements.Take(20).Select(x => x.ToString()));
+
+                if (elements.Count() > 20)
+                {
+                    text += "...";
+                }
+
+                return text;
+            }
+
+            return string.Empty;
         }
 
         #endregion

diff --git a/test/Libraries/CoreNodesTests/CoreNodeModelsTests/SelectionTests.cs b/test/Libraries/CoreNodesTests/CoreNodeModelsTests/SelectionTests.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Xml;
@@ -138,7 +138,7 @@ public void ToStringTest()
             //Checks ToString result for the selected element
             toStringResult = selection.ToString();
             string nodeType = testNode.GetType().ToString();
-            string expected = $"testPrefix : {nodeType}";
+            string expected = $"testPrefix: {nodeType}";
             Assert.AreEqual(expected, toStringResult);
 
             selectionHelperMock.VerifyAll();