Skip to content

Commit

Permalink
Add some APIs to undeclared API list file to resolve analyzer errors (#…
Browse files Browse the repository at this point in the history
…14957)

* add some APIs to undeclared API list file to resolve analyzer errors

* suppress warnings in assemblyinfo.cs files

* suppress more types

* suppress more types
  • Loading branch information
aparajit-pratap authored Feb 21, 2024
1 parent a30f1e3 commit 9223309
Show file tree
Hide file tree
Showing 6 changed files with 253 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/DynamoCore/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,7 @@
[assembly: InternalsVisibleTo("DocumentationBrowserViewExtension")]
[assembly: InternalsVisibleTo("Notifications")]


// Disable PublicAPIAnalyzer errors for this type as they're already added to the public API text file
#pragma warning disable RS0016
[assembly: TypeForwardedTo(typeof(Dynamo.Scheduler.Disposable))]
#pragma warning restore RS0016
5 changes: 4 additions & 1 deletion src/DynamoCoreWpf/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,13 @@
[assembly: InternalsVisibleTo("DynamoPlayer")]
[assembly: InternalsVisibleTo("DynamoConnector")]


// Disable PublicAPIAnalyzer errors for this type as they're already added to the public API text file
#pragma warning disable RS0016
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutSpecification))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutSection))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutElement))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutElementType))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutIncludeInfo))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.ILibraryViewCustomization))]
#pragma warning restore RS0016

3 changes: 3 additions & 0 deletions src/DynamoCoreWpf/PublicAPI.Unshipped.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2620,6 +2620,8 @@ Dynamo.ViewModels.PreferencesViewModel.DisableTrustWarnings.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableConfidenceLevelSlider.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableHideNodesToggle.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableManualScaleOverrides.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnablePanelingIsChecked.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnablePanelingIsChecked.set -> void
Dynamo.ViewModels.PreferencesViewModel.EnableTSplineIsChecked.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableTSplineIsChecked.set -> void
Dynamo.ViewModels.PreferencesViewModel.Filters.get -> System.Collections.ObjectModel.ObservableCollection<Dynamo.ViewModels.PackageFilter>
Expand Down Expand Up @@ -5063,6 +5065,7 @@ static Dynamo.Wpf.Properties.Resources.PreferencesViewEmptyStyleWarning.get -> s
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoComplete.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoCompleteTooltipText.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNotificationCenter.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnablePanelingNodes.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnablePersistExtensions.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableTSplineNodes.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewExperimentalLabel.get -> string
Expand Down
4 changes: 4 additions & 0 deletions src/DynamoUtilities/DynamoUtilities.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/DynamoUtilities/PublicAPI.Shipped.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

Loading

0 comments on commit 9223309

Please sign in to comment.