Skip to content

Commit

Permalink
Fix for element binding messagebox display on saveas (#14424)
Browse files Browse the repository at this point in the history
* remove coreclr-ncalc references

* fix for element binding messagebox on saveas
  • Loading branch information
aparajit-pratap committed Mar 19, 2024
1 parent af32824 commit c6df6e6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ internal bool Save(string filePath, bool isBackup = false, EngineController engi
{
// For intentional SaveAs either through UI or API calls, replace workspace elements' Guids and workspace Id
jo["Uuid"] = Guid.NewGuid().ToString();
if (jo["Bindings"] != JToken.Parse("[]"))
if (jo["Bindings"] != null && jo["Bindings"].Any())
{
jo["Bindings"] = JToken.Parse("[]");

Expand Down
3 changes: 2 additions & 1 deletion test/DynamoCoreWpfTests/DynamoViewTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ public void ElementBinding_SaveAs()
File.Delete(filePath);
File.Delete(saveAsPath);
}


[Test]
public void TestToastNotificationClosingBehavior()
{
var preferencesWindow = new PreferencesView(View);
Expand Down

0 comments on commit c6df6e6

Please sign in to comment.