update

DynamoDS · Apr 23, 2024 · f474446 · f474446
1 parent 63e1b5d
commit f474446
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs b/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
@@ -856,6 +856,7 @@ private void CrashGracefully(Exception ex, bool fatal = false)
 
                         if (DynamoModel.IsTestMode)
                         {
+                            // Rethrow the exception during testing.
                             throw ex;
                         }
                         return;
@@ -866,13 +867,15 @@ private void CrashGracefully(Exception ex, bool fatal = false)
                 var crashData = new CrashErrorReportArgs(ex);
                 DynamoConsoleLogger.OnLogErrorToDynamoConsole($"Unhandled exception: {crashData.Details} ");
                 Analytics.TrackException(ex, true);
-                Model?.OnRequestsCrashPrompt(crashData);
 
                 if (DynamoModel.IsTestMode)
                 {
+                    // Rethrow the exception during testing.
                     throw ex;
                 }
 
+                Model?.OnRequestsCrashPrompt(crashData);
+
                 if (fatal)
                 {
                     // Fatal exception. Close Dynamo but do not terminate the process.

diff --git a/src/DynamoCoreWpf/Views/SplashScreen/SplashScreen.xaml.cs b/src/DynamoCoreWpf/Views/SplashScreen/SplashScreen.xaml.cs
@@ -205,6 +205,12 @@ private void WebView_NavigationCompleted(object sender, CoreWebView2NavigationCo
             }
             catch (Exception ex)
             {
+                if (DynamoModel.IsTestMode)
+                {
+                    // Rethrow exception during testing.
+                    throw;
+                }
+
                 if (!DynamoModel.IsCrashing && !IsClosing)
                 {
                     CrashReportTool.ShowCrashWindow(viewModel, new CrashErrorReportArgs(ex));