replace Xceed.Wpf.Toolkit with DotNetProjects.Extended.Wpf.Toolkit #14129
Conversation
| @@ -1114,7 +1114,7 @@ public bool NodeAutocompleteMachineLearningIsBeta | |||
| { | |||
| get | |||
| { | |||
| return DynamoModel.FeatureFlags.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false); | |||
| return DynamoModel.FeatureFlags?.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false) ?? false; | |||
There was a problem hiding this comment.
this causes an exception and makes it harder to debug
There was a problem hiding this comment.
@pinzart90 what do you think about forcing this member to be nullable? It seems like the API change is worth the wasted dev and user crash time.
There was a problem hiding this comment.
This API is only used in binding to a UI element. The binding is handled by a BooleanConverter which handles nullables the same way the function is written now (at least that what the decompiler shows me)
I can convert it if you want to, it is a breaking change (I think) ...maybe it does not matter for view models.
There was a problem hiding this comment.
Let's leave it out of this PR.
| @@ -5,7 +5,6 @@ | |||
| using LiveCharts.Wpf; | |||
| using System.ComponentModel; | |||
| using System.Windows; | |||
| using System.Web.ModelBinding; | |||
There was a problem hiding this comment.
this was causing an issue on dotnet6 (it is not really needed)
|
@pinzart90 Do we need to make changes to the license.txt, about box and third party wiki with the link to the license in the new repo? |
|
(Updated: 2023-07-11-17:27:17) |
|
This doesn't look correct? Also strangely there is no change to the net6 build? |
License info:
Xceed introduced the non-commercial license on https://github.com/xceedsoftware/wpftoolkit/releases/tag/3.7.0
DotNetProjects.Extended.Wpf.Toolkit : last merge from xceed was from release 3.6.0 (dotnetprojects/WpfExtendedToolkit@66438b1)