-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Xceed.Wpf.Toolkit with DotNetProjects.Extended.Wpf.Toolkit #14129
Conversation
@@ -1114,7 +1114,7 @@ public bool NodeAutocompleteMachineLearningIsBeta | |||
{ | |||
get | |||
{ | |||
return DynamoModel.FeatureFlags.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false); | |||
return DynamoModel.FeatureFlags?.CheckFeatureFlag("NodeAutocompleteMachineLearningIsBeta", false) ?? false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this causes an exception and makes it harder to debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinzart90 what do you think about forcing this member to be nullable? It seems like the API change is worth the wasted dev and user crash time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is only used in binding to a UI element. The binding is handled by a BooleanConverter which handles nullables the same way the function is written now (at least that what the decompiler shows me)
I can convert it if you want to, it is a breaking change (I think) ...maybe it does not matter for view models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it out of this PR.
@@ -5,7 +5,6 @@ | |||
using LiveCharts.Wpf; | |||
using System.ComponentModel; | |||
using System.Windows; | |||
using System.Web.ModelBinding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was causing an issue on dotnet6 (it is not really needed)
@pinzart90 Do we need to make changes to the license.txt, about box and third party wiki with the link to the license in the new repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Updated: 2023-07-11-17:27:17) |
This doesn't look correct? Also strangely there is no change to the net6 build? |
License info:
Xceed introduced the non-commercial license on https://github.com/xceedsoftware/wpftoolkit/releases/tag/3.7.0
DotNetProjects.Extended.Wpf.Toolkit : last merge from xceed was from release 3.6.0 (dotnetprojects/WpfExtendedToolkit@66438b1)