DYN-5816 locale splash screen (#14118) #14246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Display the proper language in the Splash Screen * spacing RootDirectories * Keeping spacing * Remove Splash Screen default title * Dissect the Preferences creation from the DynamoModel ctor * removing null validation * Refactoring based on the PathManager and Preferences * Adding a PathManager and Preference singleton * cleaning text * PathManager and PreferenceSetttings as singleton * Cleaning spacing and others * Using the singleton PathManager class instead of the Interface * Changing the scope and documenting the function CreateIPathResolver * Changing access to be flexible for integrators * Removing unused function * Setting the Preferences to the RecorderTests * Add the PreferenceSettings.Instance to the DynamoCoreTests setup * Adding the preference settings to the DynamoTestUIBase Start configuration * Set the Preferences to the SystemTesttBase * Set the PreferenceSettings.Instance to the DynamoViewModelUnitTest Start * Dealing with the PathResolver * Passing the Preferences to the DynamoModel Start function and update a comment * Passing the Prererences to the VisualizationTest Start * Update the MakeCLIModel function * Passing the Preferences to the DefaultStartConfiguration * Update AssemblySharedInfo.cs * Passing the settings to the configuration from the parameter * untouch the hostApplicationDirectory * Untouching the preLoadedLibraries field and renaming * Restoring fields and adding doc * Adding the preferences to the start of some tests * Validating the settings in the DynamoModelTestBase setup * Adding Preferences to the config Settings Test * Refactoring the PathManager and Preference creation on the DynamoModel ctor and DynamoModelTestBase * Cleaning Tests setup and ignore Pref Instance property for xml * Removing Pref Singleton to the CoreTest Setup * Rollback fron the 6213 commit * keep the StartInTestMode to false since this is an special case and set an explicit preferences instance * Handling Preferences * clieaning references * Saving them with the proper Unicode * Removing Singletion Preferences * Explicit Settings since the StartInTestMode is false * Add the specific Preferences * Rollback the cc58 * Rollback the cc58 * Fix Solution * Fixing the Assembly character and test file * Forcing to update the cc58 commit * Removing the test file * Fixing Tests Unicode * No new line --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: reddyashish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Cherry-pick DYN-5816 locale splash screen (#14118)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of