Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Player internal visibility assemblies #14552

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Clean up Player internal visibility assemblies #14552

merged 2 commits into from
Dec 13, 2023

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Nov 1, 2023 •
edited
Loading

Purpose

  • Remove some now-unnecessary internal-visible assembly names.
  • Add a namespace to future-proof for a possible more general version of the Forma connector.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add and modify namespaces for Dynamo Player.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@twastvedt
Copy link
Contributor Author

@saintentropy - did you have a thought on the name of the future extension?

@BogdanZavu
Copy link
Contributor

I don't feel strongly about it but I would say to keep DynamoPlayer.Extension for now at least. Ok will all the other removals.
If we don't and somehow it turns out that later in 2025 we need some utility or to override something it might complicate things.

@QilongTang QilongTang added this to the 3.0 milestone Nov 2, 2023
@QilongTang
Copy link
Contributor

Hi @twastvedt Do need to tackle the following TODO now or in another PR?
TODO: Add the name of a possible future Forma extension so it's ready in 3.0.

@twastvedt
Copy link
Contributor Author

Hi @twastvedt Do need to tackle the following TODO now or in another PR? TODO: Add the name of a possible future Forma extension so it's ready in 3.0.

Was intended to do now. @saintentropy was going to add that to this PR.

@QilongTang
Copy link
Contributor

@twastvedt @saintentropy Any updates to this PR?

@twastvedt
Copy link
Contributor Author

@twastvedt @saintentropy Any updates to this PR?

Yes, sorry, it now looks good to us.

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

QilongTang
QilongTang approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 061a79b into master Dec 13, 2023
22 checks passed
@QilongTang QilongTang deleted the reduce-visibility branch December 13, 2023 06:51
QilongTang pushed a commit that referenced this pull request Dec 13, 2023
@twastvedt @QilongTang
Clean up Player internal visibility assemblies (#14552)
6056d4d 
* Clean up Player internal visibility assemblies

* Changes
@QilongTang QilongTang mentioned this pull request Dec 13, 2023
Merged
9 tasks
QilongTang added a commit that referenced this pull request Dec 13, 2023
@QilongTang @twastvedt
Clean up Player internal visibility assemblies (#14552) (#14753)
2e961fb 
* Clean up Player internal visibility assemblies

* Changes

Co-authored-by: Trygve Wastvedt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

@BogdanZavu BogdanZavu BogdanZavu approved these changes

@saintentropy saintentropy Awaiting requested review from saintentropy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@twastvedt @BogdanZavu @QilongTang