-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Player internal visibility assemblies #14552
Conversation
@saintentropy - did you have a thought on the name of the future extension? |
I don't feel strongly about it but I would say to keep DynamoPlayer.Extension for now at least. Ok will all the other removals. |
Hi @twastvedt Do need to tackle the following TODO now or in another PR? |
Was intended to do now. @saintentropy was going to add that to this PR. |
@twastvedt @saintentropy Any updates to this PR? |
c8cdc51
to
e08ba26
Compare
Yes, sorry, it now looks good to us. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Clean up Player internal visibility assemblies * Changes
* Clean up Player internal visibility assemblies * Changes Co-authored-by: Trygve Wastvedt <[email protected]>
Purpose
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Add and modify namespaces for Dynamo Player.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of