reduce test log noise #14705
reduce test log noise #14705
Conversation
| @@ -3,7 +3,8 @@ | |||
| ToolsVersion="16.0" | |||
| DefaultTargets="Build"> | |||
| <PropertyGroup> | |||
| <Solution>Dynamo.All.sln</Solution> | |||
| <SolutionName>Dynamo.All</SolutionName> | |||
There was a problem hiding this comment.
SolutionName is part of the msbuild common macros, but only in the VS IDE https://learn.microsoft.com/en-us/cpp/build/reference/common-macros-for-build-commands-and-properties?view=msvc-170
For console builds, we also set the property here
|
I am worried this could allow a core test to pass that should really fail. Do you think that is a possibility? |
Yes, We already have this going almost all the tests (marked as UILib) To move out all the UI tests out of core projects might be a lot of work. |
| @@ -22,7 +23,7 @@ | |||
|
|
|||
| <Target Name="RestorePackages"> | |||
| <Exec Condition="!Exists($(NuGetPath))" Command="powershell.exe -ExecutionPolicy ByPass -Command Invoke-WebRequest -Uri https://dist.nuget.org/win-x86-commandline/latest/nuget.exe -OutFile $(NuGetPath)" /> | |||
| <Exec Command="dotnet restore $(Solution) --runtime=$(RuntimeIdentifier) -p:DotNet=$(DotNet)"/> | |||
| <Exec Command="dotnet restore $(Solution) --runtime=$(RuntimeIdentifier) -p:DotNet=$(DotNet) -p:SolutionName=$(SolutionName)"/> | |||
There was a problem hiding this comment.
Why do we need to pass SolutionName to this command in addition to Solution?
Issue:
DynamoCoreTests and a couple of others are still targeting net6 (core, no wpf) because they are also part of the DynamoCore.sln
However a lot of tests in these projects still try to load/handle UI packages (that have WPF and windows references).
Fix:
In this PR I set all test projects that build part of the Dynamo.All.sln as UI libs (add windows and WPF references)
When building DynamoCore.sln we will still have the issue.
The proper fix would be to completely move out all UI related test from our core test. Until that happens we are going to see errors like "WindowsBase.dll not found" when running tests on DynamoCore