-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6397 Fix crash when parent node is deleted while node autocomplete menu is displayed #14715
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
56ba101
Fix PostDiff job
zeusongit dc250de
Merge branch 'master' of https://github.com/zeusongit/Dynamo
zeusongit 1fecd29
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 90a6c41
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 64c202b
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit d6ac751
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 255feeb
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 4e55f7f
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 1886669
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 8ac6b74
Merge branch 'master' of https://github.com/zeusongit/Dynamo
zeusongit 41c461c
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit f9cf237
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit a0adaef
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 2ab3d49
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 558df01
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit efdb82b
Merge branch 'master' of https://github.com/zeusongit/Dynamo
zeusongit 9b712f2
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 7c2dc1e
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 83bcb52
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 30b861d
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 71d23c2
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit cd1c4f9
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit 0cae237
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
zeusongit a588d14
fix
zeusongit 45eddb0
Revert different commit
zeusongit 4cfc270
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into node…
zeusongit 579b3f1
comments
zeusongit fba8e45
add unsub
zeusongit f7c3fcd
add test
zeusongit 69afd3e
Merge branch 'master' into nodeac-fix
QilongTang 35d997b
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into node…
zeusongit 4636c6d
Merge branch 'nodeac-fix' of https://github.com/zeusongit/Dynamo into…
zeusongit e1dbf02
Update NodeAutoCompleteSearchControl.xaml.cs
zeusongit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any place I can unsubscribe to this? I see that ViewModel has no property that can denote that the autocomplete menu is closed. May have to add it for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way is to pop the event all the way to DynamoViewModel level?