Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6511 Pm publish version from mypackages #14723

Merged
merged 4 commits into from
Dec 15, 2023
Merged

DYN-6511 Pm publish version from mypackages #14723

merged 4 commits into from
Dec 15, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 8, 2023 •
edited
Loading

Purpose

  • Allows the user to publish a new version of a package straight from MyPackages tab in the package manager.
  • Pulls Package data from the existing pkg.json and prepopulates the publish package form (the Name field cannot be further changed)

Also addresses concerns raised in this Jira issue: https://jira.autodesk.com/browse/DYN-6511

Chagnes

publish version

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now able to publish new package version from mypacakges
  • removed OnRequestPackagePublishDialog from tests which were not utilizing it, and rather relying on AddAllFilesAfterSelection (not sure how it was running before)

Reviewers

@reddyashish
@avidit

FYIs

@QilongTang

@dnenov
publish version from mypackages
8bcc2d1 
- now able to publish new package version from mypacakges
@dnenov dnenov changed the title publish version from mypackages Pm publish version from mypackages Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@QilongTang QilongTang added this to the 3.0 milestone Dec 9, 2023
@dnenov dnenov mentioned this pull request Dec 14, 2023
Closed
9 tasks
@dnenov
Merge remote-tracking branch 'upstream/master' into pm-update-publish…
9fc2fef 
…-version-cherrypick
@dnenov
removed user prompt from tests
577f540 
- removed OnRequestPackagePublishDialog from tests which were not utilizing it, and rather relying on AddAllFilesAfterSelection (not sure how it was running before)
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@avidit avidit changed the title Pm publish version from mypackages DYN-6511 Pm publish version from mypackages Dec 14, 2023
@reddyashish
Copy link
Contributor

passed: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1352/

@reddyashish reddyashish merged commit 5d73e14 into DynamoDS:master Dec 15, 2023
22 checks passed
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Dec 15, 2023
@dnenov @reddyashish
DYN-6511 Pm publish version from mypackages (DynamoDS#14723)
5d7e268 
* publish version from mypackages

- now able to publish new package version from mypacakges

* removed user prompt from tests

- removed OnRequestPackagePublishDialog from tests which were not utilizing it, and rather relying on AddAllFilesAfterSelection (not sure how it was running before)

* Update PackageManagerUITests.cs

(cherry picked from commit 5d73e14)
@reddyashish reddyashish mentioned this pull request Dec 15, 2023
Merged
9 tasks
QilongTang pushed a commit that referenced this pull request Dec 15, 2023
@reddyashish @dnenov
DYN-6511 Pm publish version from mypackages (#14723) (#14769)
a8c8b33 
* publish version from mypackages

- now able to publish new package version from mypacakges

* removed user prompt from tests

- removed OnRequestPackagePublishDialog from tests which were not utilizing it, and rather relying on AddAllFilesAfterSelection (not sure how it was running before)

* Update PackageManagerUITests.cs

(cherry picked from commit 5d73e14)

Co-authored-by: Deyan Nenov <[email protected]>
QilongTang added a commit that referenced this pull request Dec 16, 2023
@QilongTang
Revert "DYN-6511 Pm publish version from mypackages (#14723)"
83e4fb9 
This reverts commit 5d73e14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnenov @reddyashish @QilongTang