Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff between RC branch and 3.1 Switch on Main branch #14725

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Dec 9, 2023

Purpose

This is a roll up of cheery picks between the RC 3.0 branch and the commits before we switched to bumped main branch to 3.1

Included the following PR's
#14711 Pm remove duplicate dyf file warning from preview generation process
#14710 More fixes for webview2 tests
#14716 Remove package version limitations
#14714 Localize menu items is Graphic Element Scale dropdown
#14713 Remove dynamo sandbox app.config
#14703 Fix graph update for primitive input nodes that are first initialized to null

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

from #14711

  • dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control
  • this check is done when publishing the package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow

from #14716

  • now allows package version to start with 0
  • cannot have 0.0.0 package version

Reviewers

@sm6srw @mjkkirschner

FYIs

@pinzart90 let me know if that fix should not go in 3.0
@aparajit-pratap same ^^^

dnenov and others added 6 commits December 8, 2023 21:24
…namoDS#14711)

- dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control
- this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow

(cherry picked from commit 3ea1c5c)
Co-authored-by: pinzart <[email protected]>
(cherry picked from commit d5e6c9b)
- now allows package version to start with 0
- cannot have 0.0.0 package version

(cherry picked from commit 992e54c)
* Fix PostDiff job

* fix

(cherry picked from commit 006113e)
* remove config

* remove autogen stuff

(cherry picked from commit 0947455)
…nitialized to null (DynamoDS#14703)

* remove coreclr-ncalc references

* add failing test for dropdown node

* cleanup

* update tests

* attempt initial fix

* cleanup

* update test

* review comments

* add code comments

(cherry picked from commit 8987869)
@saintentropy saintentropy changed the base branch from master to RC3.0.0_master December 9, 2023 02:47
Copy link

github-actions bot commented Dec 9, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link

github-actions bot commented Dec 9, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@QilongTang QilongTang added this to the 3.0 milestone Dec 11, 2023
@QilongTang
Copy link
Contributor

Thank you @saintentropy while I thought PR authors would cherry-pick..

@QilongTang QilongTang merged commit 39988f5 into DynamoDS:RC3.0.0_master Dec 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants