add extra files in nugets #14774

pinzart90 · 2023-12-16T05:15:03Z

This PR addresses the following issues:
Set DynamoCorePath from systemTestBase

If the test configuration is present, then it will use its values to se the DynamoCorePath
If the test configuration is not present, then it will use the default value of Assembly.GetExecutingAssembly().Location (which should point to the SystemTestBase dll locatioN)

Adds TestServices.dll.config to the Tests nuget (this config is needed to specify the location of the Dynamo runtime folder)
Removed nunit from core nuget (added nunit deps to the test nuget)
Removed Immutable dependency from the core nuget becuse it is now part of dotnet runtime
Removed assembly names from the description (since nuget.org can now explore assemblies of packages)

More explanations on changes to SysteTestBase GetNode method:
nunit wants to resolve public types at the discovery stage. Looks like type constraints are stored with the containing type information. Basically, at the discovery stage, types referenced in "type constraints" must be resolved.
Removing the "NodeModel" type reference in the constraint ("where T : NodeModel") allows discovery to run successfully without having DynamoCore.dll included in the test output directory
Created a follow-up task (DYN-6591)to look into proper API layer for tests

github-actions · 2023-12-16T05:25:00Z

":white_check_mark: Bin-Diff Issue Resolved."
(Updated: 2023-12-22-18:49:45)

github-actions · 2023-12-16T05:37:55Z

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-16T05:39:23Z

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

test/Libraries/TestServices/App.config

pinzart90 · 2023-12-19T15:49:06Z

[run-bin-diff-net60-windows] - Files Added/Deleted::1 new file(s) have been added
The TestServices.dll.config file is added to the build output now. This is only useful during testing and to add to our nugets
@mjkkirschner @sm6srw do I need to exclude this from the installer or release builds somehow ?

mjkkirschner · 2023-12-19T16:24:49Z

[run-bin-diff-net60-windows] - Files Added/Deleted::1 new file(s) have been added The TestServices.dll.config file is added to the build output now. This is only useful during testing and to add to our nugets @mjkkirschner @sm6srw do I need to exclude this from the installer or release builds somehow ?

I would filter it out if you believe it could have some effect on behavior -
... I think you could add it here:
https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoInstall/DynamoInstall.wixproj#L77C110-L77C110

though I hope we replace this installer project eventually with just a single simple script.

github-actions · 2023-12-19T17:34:59Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-22T18:49:02Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-22T18:49:58Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-22T18:56:30Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2023-12-22T19:07:38Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

github-actions · 2024-01-03T03:59:55Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

pinzart90 · 2024-01-03T04:03:40Z

test/Libraries/SystemTestServices/SystemTestBase.cs

@@ -305,15 +306,15 @@ public void AssertPreviewCount(string guid, int count)
            Assert.AreEqual(count, data.GetElements().ToList().Count);
        }

-        public NodeModel GetNode<T>(string guid) where T : NodeModel
+        protected NodeModel GetNode(string guid)


nunit wants to resolve public types at the discovery stage. Looks like type constraints are stored with the containing type information. Basically, at the discovery stage, types referenced in "type constraints" must be resolved.
Removing the "NodeModel" type reference in the constraint ("where T : NodeModel") allows discovery to run successfully without having all dynamo assemblies included in the test outout directory

so this will yield a runtime failure now if the assembly is not resolved, but at least we'll discover the test?

Yes, it will trigger a runtime exception now (instead of compile time) if the T type is not derived from NodeModel.
I marked the method as obsolete so we will be able to replace it with something else that will not cause the same issue

mjkkirschner · 2024-01-03T18:12:57Z

tools/NuGet/build_props/DynamoVisualProgramming.Tests.props

@@ -0,0 +1,9 @@
+<Project>
+    <ItemGroup>
+        <Content Include="$(MSBuildThisFileDirectory)TestServices.dll.config">


when does this props file get used? When packing? When unpacking? At build time in the code that references this package?

I am just curious, is there a simpler way to get this config file to be copied - putting it in the lib subfolder folder does not work?

Props files (from nugets) are consumed by the project that references the nuget when running restore.
This is a pretty standard way to have both assemblies and generic files in a nuget pacakge. There is another way to add generic files (as contentFIles) but those seem to be readonly (and we need write access).
https://learn.microsoft.com/en-us/nuget/concepts/msbuild-props-and-targets#packagereference-projects

mjkkirschner · 2024-01-03T18:15:27Z

tools/NuGet/template-nuget/DynamoVisualProgramming.Core.nuspec

-            8) VMDataBridge.dll
-            9) DSCPython.dll
-            10) DynamoPackages.dll
+            Assemblies required to reference core APIs from Dynamo.


mjkkirschner · 2024-01-03T18:16:37Z

tools/NuGet/template-nuget/DynamoVisualProgramming.Core.nuspec

                <dependency id="DynamoVisualProgramming.ZeroTouchLibrary" version="$Version$"/>
-                <dependency id="Newtonsoft.Json" version="13.0.1"/>


do you think this will cause problems?

Yeah, removing it would probably cause build issues for some consumers.
NewtonSoft types still seem to be publicly exposed "near" core Dynamo APIs. I will add a task to mark those as obsolete...or move them somewhere more hidden.

yeah, it's going to be a big lift to get rid of these types as we require users to use those attributes, perhaps if those attributes are also now facaded by system.text.json we can switch it out without breaking previous builds - but needs to be determined. It was something I was hopeful we could do for 3.0, but no dice.

mjkkirschner · 2024-01-03T18:18:26Z

@pinzart90 it looks good, but I don't see the config being excluded from the installer/harvest folder and because the dynamo basepath is now set from the config in the system test base, it may affect the tests, maybe we should exclude it as you suggested above.

tools/NuGet/template-nuget/DynamoVisualProgramming.Tests.nuspec

test/Libraries/SystemTestServices/SystemTestBase.cs

github-actions · 2024-01-05T03:52:24Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

pinzart90 · 2024-01-08T14:27:39Z

@pinzart90 it looks good, but I don't see the config being excluded from the installer/harvest folder and because the dynamo basepath is now set from the config in the system test base, it may affect the tests, maybe we should exclude it as you suggested above.

The config file is now part of test nugets only (not part of the full dynamo runtime). It should not cause any issues with our existing CICD infrastructure.

pinzart90 · 2024-01-08T14:55:26Z

test/Libraries/SystemTestServices/SystemTestBase.cs

@@ -305,15 +306,27 @@ public void AssertPreviewCount(string guid, int count)
            Assert.AreEqual(count, data.GetElements().ToList().Count);
        }

-        public NodeModel GetNode<T>(string guid) where T : NodeModel


Removed the type constraint "NodeModel" because the nunit discovery process needed to resolve it.
I does not seem to matter if the method is private or public. The type constraint will still need to be resolved along with the containing type "SystemTestBase"

github-actions · 2024-01-08T21:14:24Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

mjkkirschner · 2024-01-09T04:41:33Z

test/Libraries/SystemTestServices/SystemTestBase.cs

+        /// <param name="guid">The node Guid</param>
+        /// <returns></returns>
+        /// <exception cref="Exception"></exception>
+        [Obsolete("This method will be removed in a future version of Dynamo")]


will it be replaced with some other method?

Yes, I just did not want to overcomplicate de PR now. I can change the text of the obsolete method wen the new one is implemented

github-actions · 2024-01-11T03:42:59Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

pinzart90 · 2024-01-11T14:36:57Z

passed here https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13690/

update

fa35474

pinzart90 changed the title ~~add extra files in nugets~~ [WIP] add extra files in nugets Dec 18, 2023

mjkkirschner reviewed Dec 18, 2023

View reviewed changes

test/Libraries/TestServices/App.config Outdated Show resolved Hide resolved

pinzart added 2 commits December 19, 2023 10:49

update

2492efd

Merge branch 'master' into fix_samples_tests

df39796

pinzart90 requested review from sm6srw, QilongTang and aparajit-pratap December 19, 2023 15:50

pinzart90 changed the title ~~[WIP] add extra files in nugets~~ add extra files in nugets Dec 19, 2023

Update DynamoVisualProgramming.WpfUILibrary.nuspec

55c487d

pinzart added 3 commits December 22, 2023 13:32

update

d41dea2

Update DynamoVisualProgramming.Tests.nuspec

34564e2

update

5aa4bf6

Update SystemTestBase.cs

6b5bb4b

pinzart90 added 2 commits January 2, 2024 21:24

Merge branch 'master' into fix_samples_tests

ad4ed20

update

c41b350

pinzart90 commented Jan 3, 2024

View reviewed changes

pinzart90 mentioned this pull request Jan 3, 2024

update for the Dynamo 3.0 release DynamoDS/DynamoSamples#50

Merged

mjkkirschner reviewed Jan 3, 2024

View reviewed changes

mjkkirschner approved these changes Jan 3, 2024

View reviewed changes

aparajit-pratap reviewed Jan 3, 2024

View reviewed changes

tools/NuGet/template-nuget/DynamoVisualProgramming.Tests.nuspec Outdated Show resolved Hide resolved

aparajit-pratap reviewed Jan 3, 2024

View reviewed changes

test/Libraries/SystemTestServices/SystemTestBase.cs Show resolved Hide resolved

update

9b0477a

pinzart90 requested review from mjkkirschner and aparajit-pratap January 8, 2024 14:50

pinzart90 commented Jan 8, 2024

View reviewed changes

aparajit-pratap approved these changes Jan 8, 2024

View reviewed changes

pinzart90 requested a review from aparajit-pratap January 8, 2024 16:28

sm6srw approved these changes Jan 8, 2024

View reviewed changes

Update SystemTestBase.cs

ca27bbd

mjkkirschner approved these changes Jan 9, 2024

View reviewed changes

mjkkirschner reviewed Jan 9, 2024

View reviewed changes

aparajit-pratap approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'master' into fix_samples_tests

25c02ef

pinzart90 merged commit 321d5ed into master Jan 11, 2024
20 of 21 checks passed

pinzart90 deleted the fix_samples_tests branch January 11, 2024 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add extra files in nugets #14774

add extra files in nugets #14774

pinzart90 commented Dec 16, 2023 •

edited

Loading

github-actions bot commented Dec 16, 2023 •

edited

Loading

github-actions bot commented Dec 16, 2023

github-actions bot commented Dec 16, 2023

pinzart90 commented Dec 19, 2023

mjkkirschner commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

github-actions bot commented Dec 22, 2023

github-actions bot commented Dec 22, 2023

github-actions bot commented Dec 22, 2023

github-actions bot commented Dec 22, 2023

github-actions bot commented Jan 3, 2024

pinzart90 Jan 3, 2024 •

edited

Loading

mjkkirschner Jan 3, 2024

pinzart90 Jan 8, 2024

mjkkirschner Jan 3, 2024 •

edited

Loading

mjkkirschner Jan 3, 2024

pinzart90 Jan 4, 2024

mjkkirschner Jan 3, 2024

mjkkirschner Jan 3, 2024

pinzart90 Jan 8, 2024

mjkkirschner Jan 9, 2024 •

edited

Loading

mjkkirschner commented Jan 3, 2024

github-actions bot commented Jan 5, 2024

pinzart90 commented Jan 8, 2024

pinzart90 Jan 8, 2024

github-actions bot commented Jan 8, 2024

mjkkirschner Jan 9, 2024

pinzart90 Jan 9, 2024

github-actions bot commented Jan 11, 2024

pinzart90 commented Jan 11, 2024

		<dependency id="DynamoVisualProgramming.ZeroTouchLibrary" version="$Version$"/>
		<dependency id="Newtonsoft.Json" version="13.0.1"/>

add extra files in nugets #14774

add extra files in nugets #14774

Conversation

pinzart90 commented Dec 16, 2023 • edited Loading

github-actions bot commented Dec 16, 2023 • edited Loading

github-actions bot commented Dec 16, 2023

UI Smoke Tests

github-actions bot commented Dec 16, 2023

UI Smoke Tests

pinzart90 commented Dec 19, 2023

mjkkirschner commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

UI Smoke Tests

github-actions bot commented Dec 22, 2023

UI Smoke Tests

github-actions bot commented Dec 22, 2023

UI Smoke Tests

github-actions bot commented Dec 22, 2023

UI Smoke Tests

github-actions bot commented Dec 22, 2023

UI Smoke Tests

github-actions bot commented Jan 3, 2024

UI Smoke Tests

pinzart90 Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjkkirschner Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjkkirschner Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

mjkkirschner commented Jan 3, 2024

github-actions bot commented Jan 5, 2024

UI Smoke Tests

pinzart90 commented Jan 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2024

UI Smoke Tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 11, 2024

UI Smoke Tests

pinzart90 commented Jan 11, 2024

pinzart90 commented Dec 16, 2023 •

edited

Loading

github-actions bot commented Dec 16, 2023 •

edited

Loading

pinzart90 Jan 3, 2024 •

edited

Loading

mjkkirschner Jan 3, 2024 •

edited

Loading

mjkkirschner Jan 9, 2024 •

edited

Loading