Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-3] Localize Graphic Scale Unit #14827

Merged
merged 30 commits into from
Jan 11, 2024
Merged

Conversation

zeusongit
Copy link
Contributor

Purpose

The settings file save the unit in english, hence the bug when moving to another language. Created a Map from english to localized environment. This should fix all edge cases. The settings file will always save in english language to avoid any breaking changes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@avidit @QilongTang

@zeusongit zeusongit requested a review from avidit January 10, 2024 21:17
@QilongTang QilongTang added this to the 3.0.2 milestone Jan 10, 2024
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor

Somehow self serve did not trigger on this PR, I created job https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13692/

@QilongTang
Copy link
Contributor

The second run also failed

@zeusongit
Copy link
Contributor Author

The second run also failed

Yep, as tibi mentioned in slack, it is because of the polling job failure.

Copy link

UI Smoke Tests

Test: success. 1 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor

QilongTang commented Jan 11, 2024

@QilongTang QilongTang merged commit b8d1c4e into DynamoDS:master Jan 11, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants