DYN-6337 Dropdown Show Version Descending #14828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've modified the PackageVersions list so it will return the packages versions descending (as is shown in the package detail).
|
GIF showing the expected behavior. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
Jan 11, 2024
| @@ -36,7 +36,7 @@ public int Votes | |||
| public string LatestVersion { get { return Header.versions != null ? Header.versions[Header.versions.Count - 1].version : String.Empty; } } | |||
| public string LatestVersionCreated { get { return Header.versions[Header.versions.Count - 1].created; } } | |||
|
|
|||
| public IEnumerable<string> PackageVersions { get { return Header.versions.Select(x => x.version); } } | |||
| public IEnumerable<string> PackageVersions { get { return Header.versions.OrderByDescending(x => x.version).Select(x => x.version); } } | |||
There was a problem hiding this comment.
Do we need both OrderByDescending(x => x.version) and Select(x => x.version)? I thought only the first call is enough?
There was a problem hiding this comment.
OrderByDescending(x => x.version) will return the PackageVersion object array and is expecting an string array that's why we need to use .Select(x => x.version)
QilongTang
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I've modified the PackageVersions list so it will return the packages versions descending (as is shown in the package detail).
adding @dnenov since is mentioned in the Jira task
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
I've modified the PackageVersions list so it will return the packages versions descending (as is shown in the package detail).
Reviewers
@QilongTang
FYIs
@dnenov