Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOU related notification message update #14836

Merged
merged 2 commits into from
Jan 11, 2024
Merged

TOU related notification message update #14836

merged 2 commits into from
Jan 11, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 11, 2024 •
edited
Loading

Purpose

Node AutoComplete ML related notification message update.

After:
image

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.0.2 milestone Jan 11, 2024
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 1 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 1 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit ce25037 into master Jan 11, 2024
20 of 21 checks passed
@QilongTang QilongTang deleted the NotificationUpdate branch January 11, 2024 19:54
QilongTang added a commit that referenced this pull request Jan 11, 2024
@QilongTang
TOU related notification message update (#14836)
abd6ff1 
* notification message update

* Update margin
@QilongTang QilongTang mentioned this pull request Jan 11, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Jan 11, 2024
@QilongTang
TOU related notification message update (#14836) (#14838)
0b0e7d5 
* notification message update

* Update margin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avidit avidit avidit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @avidit