Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-5743 I want to view multiline string to be better readable in Watch Node #14841

Merged
merged 1 commit into from
Jan 15, 2024
Merged

DYN-5743 I want to view multiline string to be better readable in Watch Node #14841

merged 1 commit into from
Jan 15, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 12, 2024 •
edited
Loading

Purpose

DYN-5743 I want to view multiline string to be better readable in Watch Node. As a result of this PR, long string and multi-line strings can be either more readable or with watch node resizable. The watch node resizable grip was enabled without the legacy side effect on preview bubble.
Before:
image
image

After:
image
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

multiline string is better readable in Watch Node

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.0.2 milestone Jan 12, 2024
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish
Copy link
Contributor

reddyashish commented Jan 12, 2024 •
edited
Loading

@QilongTang For a long string from code block, shouldn't the watch size node have default height? From the snapshot after your changes, watch node still has one line.

@QilongTang
Copy link
Contributor Author

@QilongTang For a long string from code block, shouldn't the watch size node have default height? From the snapshot after your changes, watch node still has one line.

The long string case would not matter because if there is no end of line in the string, watch node can't break the line for users because it would change the value of the original string. So you can see that case is still not with default height because it would only take graph space.

@QilongTang
Copy link
Contributor Author

The one failure reported in job : DynamoCoreWpfTests.GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest pass locally, not sure what's going on. It also appeared in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13704/, might be a sporadic?

@QilongTang
Copy link
Contributor Author

Self serve passed at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1396/ merging

@QilongTang QilongTang merged commit 3d6f23b into master Jan 15, 2024
20 of 21 checks passed
@QilongTang QilongTang deleted the WatchNode branch January 15, 2024 17:09
QilongTang added a commit that referenced this pull request Jan 15, 2024
@QilongTang
Re-work watch node display logic (#14841)
c525702
@QilongTang QilongTang mentioned this pull request Jan 15, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Jan 15, 2024
@QilongTang
Re-work watch node display logic (#14841) (#14843)
434f63b
QilongTang added a commit that referenced this pull request Feb 29, 2024
@QilongTang
Re-work watch node display logic (#14841)
d9a8067
@QilongTang QilongTang mentioned this pull request Feb 29, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Mar 1, 2024
@QilongTang @zeusongit @Enzo707
RC2.19.5 CherryPicks (#14989)
a1cb855 
* Re-work watch node display logic (#14841)

* improvements (#14497)

* [DYN-6455] Add warning text to selection node's initial warning (#14833)

* Fix PostDiff job

* Update Selection.cs

* made the warning persistent and then add removal code

* [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809)

* Fix PostDiff job

* Update DynamoView.xaml

* Revert UI Blocking Function calls (#14766)

* [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829)

* Fix PostDiff job

* Update NodeAutoCompleteSearchViewModel.cs

* Update

* DYN-5745 re enable copy/paste capabilities for library searchBar (#14492)

* feat(library): keydown events binding and copy/paste for clipboard management

* refactor(library): OnPasteFromClipboard function for clipboard management including comments

* DYN-6364 Skip Lucene indexing process in UIless mode (#14523)

* skip Lucene indexing process in UIless mode

* Update comments

---------

Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: Enzo Batista <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @reddyashish