DYN-6606: Make ShowCrashErrorReportWindow more robust #14862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 2 passed, 0 failed. |
mjkkirschner
approved these changes
Jan 17, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
pinzart90
approved these changes
Jan 18, 2024
| filesToSend.Add(viewModel.DumpRecordedCommands()); | ||
| try | ||
| { | ||
| filesToSend.Add(viewModel.DumpRecordedCommands()); |
There was a problem hiding this comment.
Why do we need try-catch here? This is just adding to a list.
There was a problem hiding this comment.
What if DumpRecordedCommands throws an exception ? It should not short circuit the CER report
UI Smoke TestsTest: success. 2 passed, 0 failed. |
sm6srw
added a commit
to sm6srw/Dynamo
that referenced
this pull request
Jan 18, 2024
* Make ShowCrashErrorReportWindow more robust * Address review comments. Also check minidump. * Don't add code late at night
sm6srw
added a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-6606: Update D4R OnRequestsCrashPrompt API to reflect lated dyn changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of