-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6606: Make ShowCrashErrorReportWindow more robust #14862
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
filesToSend.Add(viewModel.DumpRecordedCommands()); | ||
try | ||
{ | ||
filesToSend.Add(viewModel.DumpRecordedCommands()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need try-catch here? This is just adding to a list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if DumpRecordedCommands throws an exception ? It should not short circuit the CER report
UI Smoke TestsTest: success. 2 passed, 0 failed. |
* Make ShowCrashErrorReportWindow more robust * Address review comments. Also check minidump. * Don't add code late at night
Purpose
DYN-6606: Update D4R OnRequestsCrashPrompt API to reflect lated dyn changes
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of