Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick for 3.0.2] DYN-6606: Make ShowCrashErrorReportWindow more robust #14864

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Jan 18, 2024

Purpose

  • [Cherry pick for 3.0.2] DYN-6606: Make ShowCrashErrorReportWindow more robust

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

* Make ShowCrashErrorReportWindow more robust

* Address review comments. Also check minidump.

* Don't add code late at night
@sm6srw sm6srw changed the title [Cherry pick for 3.0.2] DYN-6606: Make ShowCrashErrorReportWindow more robust [Cherry-pick for 3.0.2] DYN-6606: Make ShowCrashErrorReportWindow more robust Jan 18, 2024
@sm6srw sm6srw added this to the 3.0.2 milestone Jan 18, 2024
@sm6srw sm6srw merged commit 8b510cb into DynamoDS:RC3.0.2_master Jan 18, 2024
19 of 20 checks passed
@sm6srw sm6srw deleted the CherryPick_DYN-6606 branch January 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant