Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN - 6645 Open File crash fix #14901

Merged
merged 1 commit into from
Jan 29, 2024
Merged

DYN - 6645 Open File crash fix #14901

merged 1 commit into from
Jan 29, 2024

Conversation

QilongTang
Copy link
Contributor

Purpose

This PR fixes a crash that the open file would crash because of missing a param null check.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.1 milestone Jan 29, 2024
@QilongTang QilongTang changed the title Open File crash fix DYN - 6645 Open File crash fix Jan 29, 2024
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit 7011be6 into master Jan 29, 2024
20 of 21 checks passed
@QilongTang QilongTang deleted the OpenFile branch January 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant