TSpline rename hashed nodes #14921
Merged
TSpline rename hashed nodes #14921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSplineSurface.BySphereCenterPointRadius TSplineSurface.ByCylinderPointsRadiu
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
@QilongTang the docs are yet to be reviewed. |
Hi @aparajit-pratap Do you mean Turbo would like to review them again, they are reviewed by Helena in Dec. |
QilongTang
pushed a commit
that referenced
this pull request
Feb 6, 2024
* DYN-6535 DynamoRevit Improve Search Fix 2 The specific case "element set parameter" was failing on Revit 2025 (not finding anything), then I've modified the code so that check if the first term is a category if that is the case it will create a specific query using the first term as category and the next terms as node name. * DYN-6535 DynamoRevit Improve Search Fix 2 Code Review Updating Linq query so that is executed only once. * Squashed commit of the following: commit 3893c85 Author: Ashish Aggarwal <[email protected]> Date: Mon Feb 5 12:53:49 2024 -0500 Fix retain package structure flow where nested directory at root level were lost (#14918) * optimize * comments and a test * add subdir test and comments * add child test * test updates commit d0bd96e Author: Aaron (Qilong) <[email protected]> Date: Fri Feb 2 15:56:03 2024 -0500 Fix API breaking changes (#14916) * Fix API breaking changes * Update OpenFileCommand * update commit 8f123fe Author: Daria Ivanciucova <[email protected]> Date: Fri Feb 2 03:20:48 2024 +0000 TSpline rename hashed nodes (#14921) * renamed 2 nodes TSplineSurface.BySphereCenterPointRadius TSplineSurface.ByCylinderPointsRadiu * TSplineSurface.ByPlaneOriginNormal * TSplineSurface.ByQuadballCenterRadius * TSplineSurface.BySphereFourPoints * TSplineSurface.ByPlaneOriginNormalXAxis * TSplineSurface.ByPlaneOriginXAxisYAxis * TSplineVertex.FunctionalValence * TSplineSurface.ByConeCoordinateSystemHeightRadii * TSplineSurface.ByPlaneBestFitThroughPoints * TSplineSurface.ByPlaneLineAndPoint * TSplineSurface.ByPlaneThreePoints * TSplineSurface.ByTorusCenterRadii * TSplineSurface.ByTorusCoordinateSystemRadii * TSplineTopology.TPointVertices * TSplineSurface.AddReflections * TSplineSurface.DeleteVertices * TSplineSurface.CompressIndices * TSplineSurface.RemoveReflections * TSplineSurface.ByNurbsSurfaceUniform * TSplineSurface.UnweldVertices * TSplineSurface.BridgeFacesToEdges * TSplineReflection.SegmentsCount * TSplineSurface.ByNurbsSurfaceCurvature * TSplineSurface.BridgeEdgesToFaces * TSplineInitialSymmetry.IsRadial; TSplineInitialSymmetry.RadialSymmetryFaces * TSplineReflection.SegmentsAngle * .TSplineSurface.BridgeFacesToFaces * TSplineSurface.BridgeEdgesToEdges * TSplineInitialSymmetry.ByRadial * SplineSurface.ByCombinedTSplineSurfaces * TSplineSurface.UncreaseVertices * BuildFromLines * TSplineSurface.CreaseVertice * TSplineTopology.RegularVertices * TSplineTopology.VertexByIndex * TSplineSurface.DeserializeFromTSM * TSplineSurface.SerializeAsTSM * TSplineTopology.BorderVertices * TSplineSurface.EnableSmoothMode * TSplineTopology.NonManifoldVertices * TSplineTopology.VerticesCoun * TSplineSurface.DuplicateFaces * TSplineSurface.ExtrudeEdgesAlongCurve * TSplineTopology.StarPointVertices * TSplineTopology.NonManifoldEdges * TSplineSurface.WeldCoincidentVertices * TSplineSurface.SubdivideFaces * TSplineSurface.ExtrudeFacesAlongCurve * TSplineSurface.ByConeCoordinateSystemHeightRadius * TSplineSurface.ByCylinderRadiusHeight commit 2bb51dc Author: Daria Ivanciucova <[email protected]> Date: Thu Feb 1 17:43:53 2024 +0000 TSpline Nodes Documentation - Third set (#14598) * FillHole, IsClosed, IsInBoxMode * BorderFaces, BorderEdges, BorderVertices, DuplicateFaces * EnableSmoothMode, ExportToTSS, ExportToTSM * ImportFromTSM (2) * ImportFromTSS(2) * ExtrudeFaces, Interpolate, SubdivideFaces, FlattenVertices (2) * IsStandard, Standardize, Thicken (2) * Decomposed (3), EdgeByIndex, EdgeCount, InnerEdges, InnerFaces, InnerVertices, NGonFaces, NonManifoldEdges, NonManifoldVertices * RegularFaces, RegularVertices, StarPoints, TPoints * Repair, Serialize, Deserialize * ExtrudeEdges, ExtrudeEdgesAlongCurve, ExtrudeFacesAlongCurve * FlipNormals, IsExtractable * MoveVertices, FaceByIndex, VertexByIndex * Is Watertight, FacesCount, VerticesCount, SlideEdges, MergeEdges, WeldCoincidentVertices, WeldVertices(2) * ToBrep, ToMesh * Update WSNXB54TDQEZRTUNRFCTUDK74DHVPQPXBXEYJUZJPW6T2F7XERDQ.md * CreateMatch (2), PullVertices * MakeUniform * updated to better method for highlighting edges * spell check * Update 6ICXLN4V6DNK5KMYTY5LPCJBE27IRW5VOBKCCVFQGO3HST752ZNQ.md * added TSM, TSS files, typos * Helena's comments --------- Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> commit 9136633 Author: Daria Ivanciucova <[email protected]> Date: Thu Feb 1 16:59:41 2024 +0000 TSpline Nodes Documentation - Second set (#14550) * TSplineInitialSymmetry nodes * TSplineReflection nodes documentation * two more Reflections nodes * 7 more nodes - Bevel Edges - Crease Edges - Crease Vertices - Uncrease Edges - Uncrease Vertices - Unweld Edges - Unweld Vertices * ByNurbs and ByCombinedSurfaces - ByNurbsSurfaceCurvature -ByNurbsSurfaceUniform - ByCombinedTSplineSurfaces * 4 Bridge nodes * Compress Indexes, BySweep, ByRevolve, BuildFromLines * DeleteEdges, DeleteFaces, DeleteVertices * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToEdges.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToFaces.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToEdges.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToFaces.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BuildFromLines.md * added missing TSplineSurface.Reflections node * Helena's comments --------- Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> commit 99cf281 Author: Deyan Nenov <[email protected]> Date: Thu Feb 1 16:58:27 2024 +0000 binding issues resolved (#14682) - fixed null exception when trying to assign click handler on a context menu button when the parent button - also fixed another incorrect binding issue commit d2e57b5 Author: Daria Ivanciucova <[email protected]> Date: Thu Feb 1 15:58:29 2024 +0000 TSpline Nodes Documentation - First set (#14549) * TSEdge and TSFace nodes documentation * TSpline Vertex nodes documentation * TSpline.UVNFrame nodes documentation * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.IsStarPoint.md * TSpline Box docs * TSplineSurface.ByPlane nodes docs * TSplineSurface.ByCone docs * TSplineSurface - Cylinder docs * TSplineSurface.ByQuadball nodes * replaced with renamed files for ByBox nodes * BySphere nodes * TSplineSurface.ByTorus nodes * BuildPipes and ByExtrude * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.Index.md * corrected the description for Torus nodes * Helena's comments --------- Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> * Revert "Squashed commit of the following:" This reverts commit c182c1b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Renamed hashed TSpline image, link to image in the .md file & Dynamo files:
TSplineTopology.RegularVertices 3FD66JH7OUVHRJOXDSO6GCVCZV63VG7PUZEMJMDZBM67ASM2XLRA
TSplineTopology.TPointVertices 3JL6REDTXILJYKG3YL47NDNEA5YHNLEAYOO3JNMRUUBMWI4GDGHA
TSplineSurface.BySphereCenterPointRadius 3W2XHZKQEZFB7P3OTUVOZUMCD3M7PKUFQZI42URWMPFARFIN2NVQ
TSplineSurface.AddReflections 6YGBDRGYLRW3BW4XJHLHBBRSCHYWA2UCJ5FQAESHDY2HMUBDUSLQ
TSplineSurface.DeleteVertices 76IVI422OMRMPHCWZHTETSZ3PJF22AOV2AX274LZCNLPCK664PGQ
TSplineTopology.VertexByIndex 7LRWGLADXMQPJN33WBBRTYBBK4NO6FQADRQICYVBDCTWPJ3FOONQ
TSplineSurface.CompressIndexes ARIV6OQ22ACATWAIKGM7OHNEJS2TQUOKUSEU6UNX6EAAVSJIMK3A
TSplineSurface.ByCylinderPointsRadius AUSALFCUDD62GV5ALRNIDJ43LBF3FWW5HY5WNAQBKRB7E2JF7WUQ
TSplineSurface.RemoveReflections B6UBJT6X5TJMS4P6CSS7JRJI6HDOCJMIND4VHXATYF2L5IPVPQBQ
TSplineSurface.ByNurbsSurfaceUniform C4KTVIQMR24V34QUQQ3FENYOOIOHKLUQ3SSJL3SVKQ2Z4QHWN4ZQ
TSplineSurface.UnweldVertices D6ESVRBW5SSM4F7J65W7OKR5DTKJAFW5F5AP23FRRR3MGXKIFVOQ
TSplineSurface.BridgeFacesToEdges DVNDD4ZUEDM4QCH35SLRIEZJLS266CIRRB7MZMMNDBI5W6UPBSQA
TSplineSurface.ByPlaneOriginNormal DWYJGQGBW2MD57NAYFKR3UEMPTHASLR2IV2X2SUK3OKI35GCEVHQ
TSplineSurface.ByQuadballCenterRadius E6WVV65M7FG2AAAGG4DXIQJPDKVNYXI5GRVNBAR4TR6T6356R2TQ
TSplineReflection.SegmentsCount GLVHD43IRWFTZKY7UVDJ7PNERQN5Z3PWTMFYVJ537HCGJCHCQQAQ
TSplineSurface.BySphereFourPoints GLX34N2BPR4CQLUZBB4FTQ47NECC2T5CQ6KSRZQXSOY6HIHL5YGQ
TSplineSurface.ByNurbsSurfaceCurvature GO6D5UXWAXIC6JMDUDLIKMABU2I4XHLVLAL77BROSGFAFN7455KA
TSplineSurface.BridgeEdgesToFaces GPVBCDN6ZVPTEE3IRF75ZGB7GIXLQYURCVYFV424TOUBVACZY44A
TSplineSurface.DeserializeFromTSM HBD752E5KQ2LBVQYS575OP546LHHTXJCD4I2NUKGZV4QDHJLBMMQ
TSplineSurface.SerializeAsTSM HPPPUZ44WSFE77XKRGFZMFM4FVPCIAERWGT6OF6U3ECKGKVBF3FA
TSplineTopology.BorderVertices HQ6POKIVNCM33NLZR7L63JAH22EKXEGGTWB4ZJMFEMLFXZYJDPHQ
TSplineSurface.ByPlaneOriginNormalXAxis IPJR2I55VFC67ZT5OYCCOOAEDH2AHY3CSCZKVXKIXALKV7IBDERA
TSplineSurface.ByPlaneOriginXAxisYAxis JDRXXB3ZLF7RXZJRV66VKV5ZDAZGN5YCY7ZLVWABJQNDVHNU4QKA
TSplineInitialSymmetry.IsRadial KB37RARA32V2WDFDQAYZ4ZFBA3AOPWGQNDOAMYU4G6VXI5W6TR3Q
TSplineInitialSymmetry.RadialSymmetryFaces KEPMQRB4UWQVYMWKTRJCLWPDVWKZZWWGLXPFTHDOMJBKQKGTWA7A
TSplineReflection.SegmentAngle M2WJT5G52MFWUUNWUZWTY2TSRSRY6GVVIAT4LLVJUC2VVLHVGW7A
TSplineSurface.BridgeFacesToFaces MQJ667AXSQFCK2Z2B7G2MNL35OIFJYLSADFLGXFJUJCA27FCHVHQ
TSplineVertex.FunctionalValence N44VZ3AJYWSL6V3DZOJYGO3ER47KV2Q6UNXWX7N6U47NDLFO3TBQ
TSplineSurface.EnableSmoothMode NN2ZH7ONXE6AF3LL2XG7BSXNABGZRF4KYTGXDYF24O5PLZ2GWW4Q
TSplineSurface.BridgeEdgesToEdges NTIOVTTOXGWZ33W6ET5JH4PSYC7L3IFSWCJV4Y3IG3CTARQGOG3A
TSplineSurface.ByConeCoordinateSystemHeightRadii O4AZYQKKSK7J5LQTW2WAZMMEFQCRSMDS5RYJ7LGVKPDRQOPRHILQ
TSplineTopology.NonManifoldVertices OIJALKI73VKASCFK5TTWV255GAJ6VI4DQDKA5BCILT7GMGHVQ3C
TSplineTopology.VerticesCount OUBDJTXQVGIEZZTOCO3QDFCDT73JUQD54U6YYFBJZUKZDZEYPYKA
TSplineInitialSymmetry.ByRadial PK6P6YKREOU7DHO6OXJFT6PUF5LSO2W7ZW4IOTGWYPW3BJYASCOQ
TSplineSurface.ByPlaneBestFitThroughPoints QMBSK3FVRYFQCMSXFIPKLNLYVY5W4C4PNN7IGZUPDZOVWUPWZNZQ
TSplineSurface.DuplicateFaces QVBZTZWGLGK2PKP6QSZJI7UBI2Y5Z7HF4ZG7JKETOZCBLOF5IIPA
TSplineSurface.ExtrudeEdgesAlongCurve RJA3JYUP36W2AR37ZYMWTK2ZDSFS6YXA5LMXE5CAYOZZDO6754CQ
TSplineTopology.StarPointVertices RMKGTFPZFLM5GGB475DWTHXFTJCBZQXE2HEVNUZA6OS72LH53HVQ
TSplineTopology.NonManifoldEdges RTIWDKESEBH6BZLFB4NRIVBLFZ72VYNZW4TBWEI6EEYG22TE6NB
TSplineSurface.ByPlaneLineAndPoint SFB4J46343LP6YKDRW2FPILSS6UXITLDXWQKYJRD6LWHQJY2IYOA
TSplineSurface.ByPlaneThreePoints SFTUBFPMM3AWPUQ6E6XPGTDHXANNIVC3ZHSMIP63ZGMSHIEQMWFQ
TSplineSurface.ByTorusCenterRadii TAX4CBLVHC7JXO4PNOKK44X5VVCC377TK4Q3R5UBTYQROUPG4VCQ
TSplineSurface.ByTorusCoordinateSystemRadii TTAJ2WGGNFLM755ADOCD3G7N4MJBQI66CAC7SXM3XCYLEIPLBOCQ
TSplineSurface.ByCombinedTSplineSurfaces U35TWGXYHIE46AYX3QP45IXNCZJAFUT62AN4GKHWSYFDMJWZ2WZQ
TSplineSurface.UncreaseVertices UCHS6CZOTWQLL24MRS4TPZS4UDBURP3SZIIW4TRSPQVRTMYBAVVA
TSplineSurface.WeldCoincidentVertices UZA22A4OYIXSIP3U5CUGNZ3WBDHIEMOS2MYI5GKTJJJFBTGI5JTA
TSplineSurface.BuildFromLines UZBX3TZTQ23FP32HELAYI7UOVGU7J6ACDZ5C3DTCYCIVJOHYWCCQ
TSplineSurface.SubdivideFaces WKY3SVAE74IVMZW7MVT4F5TGIUFXAGA2W2FN6Q6PACG3NH6AMVFA
TSplineSurface.ByConeCoordinateSystemHeightRadius WG4273QZLTXFNOZTJWMFHD4JKB67IIQBJCQNC5SMOC43VJNXKACA
TSplineSurface.ByCylinderRadiusHeight WGMB4D4GWPYAS6YAOVBQIXYPGCBRH3KEF437CWWZGSXVEZXLRGTQ
TSplineSurface.ExtrudeFacesAlongCurve XTER6KGCJ3OP43RH5L4IEBVIW7JTSDB46DYI7BVE2UMG3DXB7HLQ
TSplineSurface.CreaseVertices ZLORG7PG4XWDBYXJHH7YVPDCIU4QYMZWAMABFPVWNAZ7VTQTX2YQ
checked that documentation displays image and can import dynamo script for the nodes mentioned above
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@QilongTang
FYIs
@dnenov @Amoursol