Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analytics log to record correct guide name when rating. #14926

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

Update analytics log to record correct guide name when rating

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang
Copy link
Contributor

I forgot, was the RatingTextTitle always empty or just single word?

@QilongTang QilongTang added this to the 3.1 milestone Feb 7, 2024
@zeusongit
Copy link
Contributor Author

I forgot, was the RatingTextTitle always empty or just single word?

It was Rate this guide

@QilongTang
Copy link
Contributor

I forgot, was the RatingTextTitle always empty or just single word?

It was Rate this guide

Gotcha, can you also check if GuideName is localized? If yes, we want to send the Eng version

Copy link

github-actions bot commented Feb 7, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit
Copy link
Contributor Author

zeusongit commented Feb 7, 2024

I forgot, was the RatingTextTitle always empty or just single word?

It was Rate this guide

Gotcha, can you also check if GuideName is localized? If yes, we want to send the Eng version

Yes confirmed, GuideName always has the eng string.

@zeusongit zeusongit merged commit 091cbbf into DynamoDS:master Feb 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants