-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DynamoVisualProgramming.ZeroTouchLibrary.nuspec to support multitarget #14943
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
<group targetFramework="$TargetFramework$"> | ||
<dependency id="DynamoVisualProgramming.DynamoServices" version="$Version$"/> | ||
</group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove this block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need both target framework groups :
netstandard2.0 and whatever current dynamo will target
netstandard2.0 will not have the DynamoUnits assembly (since that is targeting net6)
<file src="ProtoGeometry.dll" target="lib\$TargetFramework$" /> | ||
<file src="ProtoGeometry.xml" target="lib\$TargetFramework$" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and these two lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are needed for the net8 configurations
Nuget does not know to pick some assemblies form netstandard and the rest from net8. It goes for one targetframework or the other. So both need all assemblies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does this nuspec create a multi-targeting nuget package targeting net8 containing all these assemblies and also targeting netstandard2 with only protogeometry and dynamoservices assemblies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will allow some zero touch packages to target nestandard2.0 so that it can be compatible with both Dynamo 2.19 and Dynamo 3.0
Add netstandard2.0 target for ZeroTouchLibrary
ZeroTouchLibrary could be used for libraries that need to support both 2.19 and 3.0 versions of Dynamo