Update DynamoVisualProgramming.ZeroTouchLibrary.nuspec to support multitarget #14943
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
pinzart90
changed the title
| <group targetFramework="$TargetFramework$"> | ||
| <dependency id="DynamoVisualProgramming.DynamoServices" version="$Version$"/> | ||
| </group> |
There was a problem hiding this comment.
Do we need to remove this block?
There was a problem hiding this comment.
I think we need both target framework groups :
netstandard2.0 and whatever current dynamo will target
netstandard2.0 will not have the DynamoUnits assembly (since that is targeting net6)
| <file src="ProtoGeometry.dll" target="lib\$TargetFramework$" /> | ||
| <file src="ProtoGeometry.xml" target="lib\$TargetFramework$" /> |
There was a problem hiding this comment.
and these two lines?
There was a problem hiding this comment.
they are needed for the net8 configurations
Nuget does not know to pick some assemblies form netstandard and the rest from net8. It goes for one targetframework or the other. So both need all assemblies
There was a problem hiding this comment.
So does this nuspec create a multi-targeting nuget package targeting net8 containing all these assemblies and also targeting netstandard2 with only protogeometry and dynamoservices assemblies?
There was a problem hiding this comment.
It will allow some zero touch packages to target nestandard2.0 so that it can be compatible with both Dynamo 2.19 and Dynamo 3.0
Add netstandard2.0 target for ZeroTouchLibrary
ZeroTouchLibrary could be used for libraries that need to support both 2.19 and 3.0 versions of Dynamo