Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some APIs to undeclared API list file to resolve analyzer errors #14957

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Add some APIs to undeclared API list file to resolve analyzer errors #14957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3602390
add some APIs to undeclared API list file to resolve analyzer errors
aparajit-pratap Feb 20, 2024
00c7e56
suppress warnings in assemblyinfo.cs files
aparajit-pratap Feb 20, 2024
e117756
suppress more types
aparajit-pratap Feb 20, 2024
315360b
suppress more types
aparajit-pratap Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/DynamoCore/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,7 @@
[assembly: InternalsVisibleTo("DocumentationBrowserViewExtension")]
[assembly: InternalsVisibleTo("Notifications")]


// Disable PublicAPIAnalyzer errors for this type as they're already added to the public API text file
#pragma warning disable RS0016
[assembly: TypeForwardedTo(typeof(Dynamo.Scheduler.Disposable))]
#pragma warning restore RS0016
5 changes: 4 additions & 1 deletion src/DynamoCoreWpf/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,13 @@
[assembly: InternalsVisibleTo("DynamoPlayer")]
[assembly: InternalsVisibleTo("DynamoConnector")]


// Disable PublicAPIAnalyzer errors for this type as they're already added to the public API text file
#pragma warning disable RS0016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so even if these types are added to the unshipped list we still get errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not sure why this is happening.

[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutSpecification))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutSection))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutElement))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutElementType))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.LayoutIncludeInfo))]
[assembly: TypeForwardedTo(typeof(Dynamo.Wpf.Interfaces.ILibraryViewCustomization))]
#pragma warning restore RS0016

3 changes: 3 additions & 0 deletions src/DynamoCoreWpf/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,6 +2620,8 @@ Dynamo.ViewModels.PreferencesViewModel.DisableTrustWarnings.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableConfidenceLevelSlider.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableHideNodesToggle.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableManualScaleOverrides.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnablePanelingIsChecked.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnablePanelingIsChecked.set -> void
Dynamo.ViewModels.PreferencesViewModel.EnableTSplineIsChecked.get -> bool
Dynamo.ViewModels.PreferencesViewModel.EnableTSplineIsChecked.set -> void
Dynamo.ViewModels.PreferencesViewModel.Filters.get -> System.Collections.ObjectModel.ObservableCollection<Dynamo.ViewModels.PackageFilter>
Expand Down Expand Up @@ -5063,6 +5065,7 @@ static Dynamo.Wpf.Properties.Resources.PreferencesViewEmptyStyleWarning.get -> s
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoComplete.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoCompleteTooltipText.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNotificationCenter.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnablePanelingNodes.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnablePersistExtensions.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableTSplineNodes.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewExperimentalLabel.get -> string
Expand Down
4 changes: 4 additions & 0 deletions src/DynamoUtilities/DynamoUtilities.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/DynamoUtilities/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

Loading
Loading