Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYN-6616] Restore the Not Authenticated message when an unauthenticated user triggers ML Nodeautocomplete #14959

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[DYN-6616] Restore the Not Authenticated message when an unauthenticated user triggers ML Nodeautocomplete #14959

merged 1 commit into from
Feb 22, 2024

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Feb 21, 2024 •
edited
Loading

Purpose

The PR restores the not Authenticated message when an unauthenticated user triggers ML Nodeautocomplete suggestions.
(This will not trigger login, unlike 2.19)

DynamoSandbox_wfUt8JjZ3T

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Restore the Not Authenticated message when an unauthenticated user triggers ML Nodeautocomplete

Reviewers

@DynamoDS/dynamo

FYIs

@Amoursol

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Feb 22, 2024
@QilongTang
Copy link
Contributor

@aparajit-pratap PR like this I would not expect the API breaking analysis to fail?

@QilongTang QilongTang merged commit 051b380 into DynamoDS:master Feb 22, 2024
21 of 22 checks passed
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Feb 28, 2024
@zeusongit
check for token (DynamoDS#14959)
f94cb46
@zeusongit zeusongit modified the milestones: 3.1, 3.0.4 Feb 28, 2024
@zeusongit zeusongit mentioned this pull request Feb 28, 2024
Merged
9 tasks
@zeusongit zeusongit modified the milestones: 3.0.4, 3.1 Feb 28, 2024
QilongTang pushed a commit that referenced this pull request Feb 28, 2024
@zeusongit
check for token (#14959) (#14983)
3451fd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zeusongit @QilongTang