homePage loading from code behind #14991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed the homePage from the visual tree of DynamoView and deterred creating until DynamoView is loaded
- I had to ignore most of the HomePageTests because the `IsNewAppHomeEnabled` comes as false when using the `DynamoTestUIBase` - to discuss with the team
UI Smoke TestsTest: success. 2 passed, 0 failed. |
- name of framework element was causing the test to fail, renamed accordingly - added descriptive failure messages to more easily identify the cause of the fail
dnenov
changed the title
reddyashish
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
@dnenov Will be addressed the ignored tests in a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Attempt to resolve master build timeout after introducing the new Dynamo homePage by removing the control from DynamoView visual tree, and only adding it after DynamoView has fully loaded.
Most of the HomePageTests were ignored because the
IsNewAppHomeEnabledis set to false when usingDynamoTestUIBaseand the HomePage is not loaded.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@mjkkirschner
FYIs