Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6619-Localizing-StreamWriter-Exception #15000

Closed
wants to merge 1 commit into from
Closed

DYN-6619-Localizing-StreamWriter-Exception #15000

wants to merge 1 commit into from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Localizing System StreamWriter exception
I added a static class and a static method that will throw a DirectoryNotFoundException with the translated string (added in Resources.resx). If we want to add more exceptions we will need to modify the LocalizedExceptionHelper to include the new one.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Localizing System StreamWriter exception

Reviewers

@QilongTang

FYIs

I added a static class and a static method that will throw a DirectoryNotFoundException with the translated string (added in Resources.resx).
If we want to add more exceptions we will need to modify the LocalizedExceptionHelper to include the new one.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the expected behavior.
EmpJgQRyim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant