Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6774 cherry pick [DYN-6621] so that splash screen close works. #15018

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mjkkirschner
Copy link
Member

Purpose

splash screen web app calls a new method that is missing in 2.19.5 - cherry pick the PR that introduced it from master.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

…namoDS#14866)

* Update SplashScreen.xaml.cs

* Update SplashScreen.xaml.cs
@QilongTang QilongTang added this to the 2.19.5 milestone Mar 14, 2024
@mjkkirschner
Copy link
Member Author

mjkkirschner commented Mar 15, 2024

@QilongTang @sm6srw all the geometry and viz tests are failing on this 2.19.5 build, I am assuming this is because we are installing 230 only on pullRequestvalidation job - what do we install on master-15 complete install test job?

This build only supports 229 and 228.5 :(

@QilongTang
Copy link
Contributor

@QilongTang @sm6srw all the geometry and viz tests are failing on this 2.19.5 build, I am assuming this is because we are installing 230 only on pullRequestvalidation job - what do we install on master-15 complete install test job?

This build only supports 229 and 228.5 :(

I triggered a new 2.19.5 build today and it passed so master-15 is for sure good to run all the tests. I will merge and trigger a build for you

@QilongTang QilongTang merged commit cdf8c5a into DynamoDS:RC2.19.5_master Mar 15, 2024
21 of 23 checks passed
@mjkkirschner mjkkirschner deleted the 2195ss branch March 15, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants