Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PRs 14394, 14424, 14500, 14740 #15032

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Mar 19, 2024

Purpose

Cherry-pick PRs #14394, #14424, #14500, #14740

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Clear element binding data from DYN upon Save As
  • Don't save file to recent files list if Save As is canceled
  • Add provision of tooltips to message boxes

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

aparajit-pratap and others added 6 commits March 14, 2024 14:18
…nitialized to null (DynamoDS#14703)

* remove coreclr-ncalc references

* add failing test for dropdown node

* cleanup

* update tests

* attempt initial fix

* cleanup

* update test

* review comments

* add code comments
@aparajit-pratap aparajit-pratap changed the base branch from master to RC2.19.5_master March 19, 2024 17:16
* remove coreclr-ncalc references

* fix for element binding messagebox on saveas
@aparajit-pratap aparajit-pratap changed the title Cherry-pick PRs 14394, 14740 Cherry-pick PRs 14394, 14424, 14500, 14740 Mar 19, 2024
@QilongTang QilongTang added this to the 2.19.5 milestone Mar 19, 2024
@QilongTang
Copy link
Contributor

Is the element binding one a must have? Because that cherry pick introduce new resource strings while the localization process is done for 2.19.5

@mjkkirschner
Copy link
Member

mjkkirschner commented Mar 19, 2024

should the element binding change really be made in 2.19? I thought that should only go into 3.0 - why would we cherry pick an API break like that?

Ah, sorry I think I am getting confused between the SaveAs dropping element binding change and the element binding serialization format change - please ignore me.

@mjkkirschner
Copy link
Member

Is the element binding one a must have? Because that cherry pick introduce new resource strings while the localization process is done for 2.19.5

IMO - having the dialog which a user could translate themselves with more info is better than not having it - alternatively we could make it a known issue... which we also don't translate ;)

@aparajit-pratap
Copy link
Contributor Author

Is the element binding one a must have? Because that cherry pick introduce new resource strings while the localization process is done for 2.19.5

IMO - having the dialog which a user could translate themselves with more info is better than not having it - alternatively we could make it a known issue... which we also don't translate ;)

I agree with having the messaging even if it's missing localization as it will be good to have something than nothing at all.

@QilongTang
Copy link
Contributor

QilongTang commented Mar 20, 2024

Two regressions remaining, see https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/15161/
Oh looks like everything is good in the next job, LGTM

@QilongTang QilongTang merged commit 7685bfb into DynamoDS:RC2.19.5_master Mar 20, 2024
22 of 23 checks passed
@aparajit-pratap aparajit-pratap deleted the RC2.19.5_master branch March 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants