Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash/freeze on systems with no AdskIdentityManager or any adsk product #15042

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-6799
Expanded the region of try-catch to include init API that throws an exception when Dynamo is launched on clean machine with no autodesk product or no Adsk Identity Manager.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@DynamoDS/dynamo

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

}
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any time we return false, should we perhaps also log something to the console?

@QilongTang QilongTang modified the milestones: 2.19.5, 3.1 Mar 21, 2024
@zeusongit zeusongit merged commit ea1238e into DynamoDS:master Mar 22, 2024
18 checks passed
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Mar 22, 2024
…roduct (DynamoDS#15042)

* Update IDSDKManager.cs

* Update IDSDKManager.cs

* add logs
QilongTang pushed a commit that referenced this pull request Mar 22, 2024
…or any adsk product (#15042) (#15048)

* Fix crash/freeze on systems with no AdskIdentityManager or any adsk product (#15042)

* Update IDSDKManager.cs

* Update IDSDKManager.cs

* add logs

* revert resource designer ver

* remove logs from cherrypick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants