Update Open Template hotkey label

[zeusongit]

Purpose

Update hotkey label for open template.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@avidit @QilongTang

[QilongTang]

My bad, I think I noticed from last PR but forgot to point it out 👍🏻

[zeusongit]

My bad, I think I noticed from last PR but forgot to point it out 👍🏻

I also found the conflicting hotkey:

Dynamo/src/DynamoCoreWpf/Views/Core/DynamoView.xaml

Line 185 in 765542d

<KeyBinding Key="T"

[QilongTang]

My bad, I think I noticed from last PR but forgot to point it out 👍🏻

I also found the conflicting hotkey:

Dynamo/src/DynamoCoreWpf/Views/Core/DynamoView.xaml

Line 185 in 765542d

<KeyBinding Key="T"

Oh I am pretty sure we obsoleted presets function so maybe we can just take the shortcut instead of using Shift. You can search the code for that command, I bet no reference?

[zeusongit]

My bad, I think I noticed from last PR but forgot to point it out 👍🏻

I also found the conflicting hotkey:

Dynamo/src/DynamoCoreWpf/Views/Core/DynamoView.xaml

Line 185 in 765542d

<KeyBinding Key="T"

Oh I am pretty sure we obsoleted presets function so maybe we can just take the shortcut instead of using Shift. You can search the code for that command, I bet no reference?

I did not see any code marked obsolete.
The command is referencing this method:

Dynamo/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

Line 2541 in 765542d

private void ShowNewPresetStateDialogAndMakePreset(object parameter)

[github-actions]

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

[QilongTang]

My bad, I think I noticed from last PR but forgot to point it out 👍🏻

I also found the conflicting hotkey:

Dynamo/src/DynamoCoreWpf/Views/Core/DynamoView.xaml

Line 185 in 765542d

<KeyBinding Key="T"

Oh I am pretty sure we obsoleted presets function so maybe we can just take the shortcut instead of using Shift. You can search the code for that command, I bet no reference?

I did not see any code marked obsolete. The command is referencing this method:

Dynamo/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

Line 2541 in 765542d

private void ShowNewPresetStateDialogAndMakePreset(object parameter)

Surprisingly the command still works but I remember this feature was obsoleted... I think @mjkkirschner should know because he developed preset function and I remember it was deprecated based on analytics.

[QilongTang]

I got confirmation from @Amoursol that we can take Ctrl + T for template function because preset function should have been deprecated (We were supposed to remove all the code related in 3.0 but did not have scope)

[zeusongit]

I got confirmation from @Amoursol that we can take Ctrl + T for template function because preset function should have been deprecated (We were supposed to remove all the code related in 3.0 but did not have scope)

Alright, I will amend the PR accordingly.

[zeusongit]

Is it fine to mark ShowNewPresetStateDialogAndMakePreset as obsolete?

[QilongTang]

Is it fine to mark ShowNewPresetStateDialogAndMakePreset as obsolete?

Yes