-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Open Template hotkey label #15053
Conversation
My bad, I think I noticed from last PR but forgot to point it out 👍🏻 |
I also found the conflicting hotkey:
|
Oh I am pretty sure we obsoleted presets function so maybe we can just take the shortcut instead of using |
I did not see any code marked obsolete.
|
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Surprisingly the command still works but I remember this feature was obsoleted... I think @mjkkirschner should know because he developed preset function and I remember it was deprecated based on analytics. |
I got confirmation from @Amoursol that we can take |
Alright, I will amend the PR accordingly. |
Is it fine to mark |
Yes |
Purpose
Update hotkey label for open template.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@avidit @QilongTang