Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN 6551 package manager not preserving sort order after search #15054

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR for DYN-6551 : Package manager not preserving sort order after search. The package manager will now keep the user-defined sorting order after a search text is entered and cleared. Unit test included.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

The package manager will now keep the user-defined sorting order after a search text is entered and cleared.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Mar 25, 2024
@QilongTang QilongTang marked this pull request as ready for review March 25, 2024 19:09
@QilongTang QilongTang merged commit fea0da7 into DynamoDS:master Mar 25, 2024
22 checks passed
@QilongTang QilongTang changed the title Dyn 6551 package manager not preserving sort order after search DYN 6551 package manager not preserving sort order after search Mar 25, 2024
@Amoursol
Copy link
Contributor

@ivaylo-matov for histories sake, could you please add a GIF into this PR? This helps with us understanding as time goes on what happened, and is also used in presentations and the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants