Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5738-Homepage drag&drop feature #15059

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Mar 26, 2024

Purpose

Enables drag & drop file feature on Start page as described in this jira task: https://jira.autodesk.com/browse/DYN-5738

  • The user Drag & Drop a .dyn or .dyf file into Dynamo
  • *.dyn or *.dyf extension constraint, other type of file would not work
  • To the StartPage or another part that means an initial state, Dynamo will open the file

DynamoSandbox_CDtwCpqdv7

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • implemented drag and drop behavior for .dyn and .dyf files
  • added test for the new feature. the test is passing, but ignored as webView2 initialization still causes time out on master-15

Reviewers

@QilongTang

FYIs

@Amoursol

- implemented drag and drop behavior for .dyn and .dyf files
- added test for the new feature. the test is passing, but ignored as webView2 initialization still causes time out on master-15
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@dnenov dnenov requested a review from QilongTang March 26, 2024 12:33
@Amoursol
Copy link
Contributor

Thanks for adding this feature back in @dnenov !

@QilongTang QilongTang added this to the 3.1 milestone Mar 26, 2024
@QilongTang QilongTang merged commit 0c8fe05 into DynamoDS:master Mar 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants