upgrade fflags #15060
Merged
upgrade fflags #15060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzart90
commented
Mar 26, 2024
| @@ -107,7 +107,7 @@ internal FeatureFlagsClient(string userkey, string mobileKey = null, bool testMo | |||
| internal void Init(string mobileKey) | |||
| { | |||
| //start up client. | |||
| ldClient = LaunchDarkly.Sdk.Client.LdClient.Init(mobileKey, user,TimeSpan.FromSeconds(5)); | |||
| ldClient = LaunchDarkly.Sdk.Client.LdClient.Init(mobileKey, LaunchDarkly.Sdk.Client.ConfigurationBuilder.AutoEnvAttributes.Disabled, user, TimeSpan.FromSeconds(5)); | |||
There was a problem hiding this comment.
link on ff API changes https://docs.launchdarkly.com/sdk/client-side/dotnet/migration-3-to-4
UI Smoke TestsTest: success. 2 passed, 0 failed. |
sm6srw
approved these changes
Mar 27, 2024
aparajit-pratap
approved these changes
Mar 27, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades feature flags in order to fix a reported security issue
DYN-6777
There was a change in on of the APIs we used. The change is relatively safe because DynamoFeatureFlags is part of a separate process