Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage - revert recent changes #15061

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Mar 26, 2024

Purpose

Revert recent changes to homepage under test mode. Fixes timeout on master-15.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • revert changes that allowed homepage to be initialized under test mode which is still causing timeout on master-15

Reviewers

@QilongTang

FYIs

- revert changes that allowed homepage to be initialized under test mode which is still causing timeout on master-15
@dnenov dnenov requested a review from QilongTang March 26, 2024 19:55
@QilongTang QilongTang merged commit 1a580cf into DynamoDS:master Mar 26, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants