DYN-4449 Undo in group casues weird visual artifacts #15067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectors in groups remain collapsed on undo
|
Will check the fail tomorrow morning.... |
second PR attempt
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
All looks okay now |
mjkkirschner
reviewed
Apr 2, 2024
| /// Consequently, if a group is collapsed and then moved, performing an Undo operation will not restore | ||
| /// the connector to its state at the time the move was recorded. | ||
| /// </summary> | ||
| private void SetCollapsedByNodeViewModel() |
There was a problem hiding this comment.
it seems like you could write a unit test for the Redraw method that makes sure IsCollapsed is true when it should be.
There was a problem hiding this comment.
please see the test included. hope that's okay.
QilongTang
changed the title
QilongTang
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Undo in group causes weird visual artifacts. On undo connectors will be visible even though the group that they are in is collapsed. I added a method that that is executed on Redrawn and evaluates whether both nodes associated with connector are collapsed, if so, collapses the connector itself.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Connectors are only recorded in the Undo stack when they are connected. Consequently, if a group is collapsed and then moved, performing an Undo operation will not restore the connector to its state at the time the move was recorded. The new method evaluates whether both nodes associated with a connector are collapsed, if so, collapses the connector itself.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol