Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5149 ensures connectorPins are included in SelectNeighbors #15091

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Apr 5, 2024

Purpose

Small PR that adds related Connector Pins to selection when user uses Tab key to select neighboring nodes. Includes unit test thanks to @dnenov.
Supersedes #15007 (build keeps failing)

DYN-5149-fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

When selecting a node and hitting "tab" it automatically adds the connected nodes to the selection. This is super handy for moving groups of nodes around. The selection will now include not only the next connected node, but all pins of the connectors at the same time.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

includes unit test thanks to dnenov
Copy link

github-actions bot commented Apr 5, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish reddyashish marked this pull request as ready for review April 5, 2024 14:53
@QilongTang QilongTang added this to the 3.1 milestone Apr 8, 2024
@QilongTang QilongTang merged commit 7dfcdd6 into DynamoDS:master Apr 8, 2024
22 checks passed
@QilongTang QilongTang changed the title ensures connectorPins are included in SelectNeighbors DYN-5149 ensures connectorPins are included in SelectNeighbors Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants