Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regression Nodes Documentation #15097

Closed
wants to merge 4 commits into from
Closed

Fix Regression Nodes Documentation #15097

wants to merge 4 commits into from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

New nodes were added but the ProducesCorrectOutputFromCoreDirectory_preloadedbinaries() test was not updated to reflect the changes. Then in this fix I'm just increasing the hardcoded value to match the expected nodes documentation.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang @dnenov

FYIs

RobertGlobant20 and others added 4 commits April 5, 2024 08:55
New nodes were added but the ProducesCorrectOutputFromCoreDirectory_preloadedbinaries() test was not updated to reflect the changes. Then in this fix I'm just increasing the hardcoded value to match the expected nodes documentation.
@RobertGlobant20
Copy link
Contributor Author

Screenshot of the ProducesCorrectOutputFromCoreDirectory_preloadedbinaries() test passing with the fix
image

@QilongTang
Copy link
Contributor

@RobertGlobant20 Would you re-open this PR with updated base from master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants