Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyn 6821 home page links fix #15098

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 8, 2024

Purpose

Addresses this Jira issue: DYN-6821 Fixes HomePage links.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixes homepage links
  • this was broken during the drag&drop implementation

Reviewers

@reddyashish

FYIs

@Amoursol

@dnenov dnenov requested a review from reddyashish April 8, 2024 17:16
@QilongTang
Copy link
Contributor

Sorry @dnenov I think our team rebased master branch so your DYN-6821-HomePage-links-fix had the wrong base branch and contained changes unintended for master now, would you rebase your changes?

@dnenov
Copy link
Collaborator Author

dnenov commented Apr 9, 2024

Sorry @dnenov I think our team rebased master branch so your DYN-6821-HomePage-links-fix had the wrong base branch and contained changes unintended for master now, would you rebase your changes?

Thanks for the heads up @QilongTang ! Reverted the changes in both my affected PRs

@QilongTang
Copy link
Contributor

hi @dnenov I think you still have a few deletion change needs to be reverted

@@ -1,123 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these resources not used anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes came from a revert change by Roberto earlier but I had to force push to wipe it so causing some confusion here. They are not meant to be included in the PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I missed those .. I'm sorry guys.

Copy link

github-actions bot commented Apr 9, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Apr 9, 2024
@QilongTang QilongTang merged commit 26f992a into DynamoDS:master Apr 9, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants