-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-4654 Revert IO node development for 3.1 #15110
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
@twastvedt have you evaluated a feature flag or DEBUG condition instead of reverting so that more eyes, and daily build users get banging on this node earlier? |
We'd be interested in a feature flag for the node itself. We were concerned though about some of the apis we're adding that may need to be public but that aren't fully baked yet. |
Still need to validate the testing... Not sure why it is still pending |
FYI @QilongTang |
@twastvedt Looks like this PR is opened when master-5 checks were not reporting regressions. I found the following regressions in this PR: |
Purpose
We're only part-way on IO node development. We'll keep the development in a feature branch until after 3.1. (See https://github.com/DynamoDS/Dynamo/tree/DYN-4654-io-node).
This reverts the two PRs so far merged for the IO node:
#14987
#15037
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of