Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-4654 Revert IO node development for 3.1 #15110

Merged
merged 2 commits into from
Apr 15, 2024
Merged

DYN-4654 Revert IO node development for 3.1 #15110

merged 2 commits into from
Apr 15, 2024

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Apr 10, 2024 •
edited
Loading

Purpose

We're only part-way on IO node development. We'll keep the development in a feature branch until after 3.1. (See https://github.com/DynamoDS/Dynamo/tree/DYN-4654-io-node).

This reverts the two PRs so far merged for the IO node:
#14987
#15037

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@twastvedt
Revert "DYN-6607 - Input/Output Node - part 1 FIX (#15037)"
4838e90 
This reverts commit 97e2d46.

# Conflicts:
#	test/Tools/NodeDocumentationMarkdownGeneratorTests/MarkdownGeneratorCommandTests.cs
@twastvedt
Revert "DYN-6607 - Input/Output Node - part 1 (#14987)"
0fec775 
This reverts commit c90f105.
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@mjkkirschner
Copy link
Member

mjkkirschner commented Apr 10, 2024 •
edited
Loading

@twastvedt have you evaluated a feature flag or DEBUG condition instead of reverting so that more eyes, and daily build users get banging on this node earlier?

@twastvedt
Copy link
Contributor Author

We'd be interested in a feature flag for the node itself. We were concerned though about some of the apis we're adding that may need to be public but that aren't fully baked yet.

@saintentropy saintentropy added this to the 3.1 milestone Apr 14, 2024
@saintentropy
Copy link
Contributor

Still need to validate the testing... Not sure why it is still pending

@saintentropy
Copy link
Contributor

FYI @QilongTang

@twastvedt twastvedt changed the base branch from master to RC3.1.0_master April 15, 2024 15:48
@QilongTang QilongTang merged commit 83e388a into RC3.1.0_master Apr 15, 2024
22 of 23 checks passed
@QilongTang QilongTang deleted the DYN-4654-revert-io-node-3.1 branch April 15, 2024 15:55
@QilongTang
Copy link
Contributor

QilongTang commented Apr 15, 2024 •
edited
Loading

@twastvedt Looks like this PR is opened when master-5 checks were not reporting regressions. I found the following regressions in this PR:
Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings
NodeDocumentationMarkdownGeneratorTests.MarkdownGeneratorCommandTests.ProducesCorrectOutputFromCoreDirectory_preloadedbinaries

@twastvedt twastvedt mentioned this pull request Apr 15, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintentropy saintentropy saintentropy approved these changes

@QilongTang QilongTang QilongTang approved these changes

@dnenov dnenov Awaiting requested review from dnenov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@twastvedt @mjkkirschner @saintentropy @QilongTang