Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4344 hotkey to unpin all node previews #15117

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Apr 11, 2024

Purpose

Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.
Test also included.

DYN-4344-Hotkey to unpin all previews

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

Copy link

github-actions bot commented Apr 11, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@Amoursol
Copy link
Contributor

This is awesome :D Thanks so much @ivaylo-matov

@QilongTang QilongTang added this to the 3.2 milestone Apr 11, 2024
@QilongTang QilongTang marked this pull request as ready for review April 14, 2024 18:26
@avidit avidit changed the title Dyn 4344 hotkey to unpin all node previews DYN-4344 hotkey to unpin all node previews Apr 29, 2024
@reddyashish
Copy link
Contributor

LGTM with one comment.

@QilongTang
Copy link
Contributor

@QilongTang
Copy link
Contributor

@pinzart90 Were you trying to merge master into this branch, to solve the regression reported?

@pinzart90
Copy link
Contributor

@pinzart90 Were you trying to merge master into this branch, to solve the regression reported?

Yes, but the problem still persists. It is actually caused by the new test. I am working on a fix and will push to this PR

@ivaylo-matov
Copy link
Contributor Author

sorry for the delay... looking into it now. seem like the new test is causing the next two test to fail regardless of the order. All run okay if I move it last, but I assume this won't be acceptable?

UnpinPreviewBubble() was not updating the nodeViewModel
@ivaylo-matov
Copy link
Contributor Author

hopefully the last commit will solve this regression 🤞

@reddyashish
Copy link
Contributor

The failing test here is from GNM test suite [DynamoCoreWpfTests.GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest] which is flaky. @QilongTang good to merge this?

@QilongTang
Copy link
Contributor

@QilongTang
Copy link
Contributor

QilongTang commented May 3, 2024

The failing test here is from GNM test suite [DynamoCoreWpfTests.GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest] which is flaky. @QilongTang good to merge this?

Good point, This one should be good to go from the last Dynamo Self Serve run, merging.

@QilongTang QilongTang merged commit 1c71fa5 into DynamoDS:master May 3, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants