Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Failure for AggregateRenderPackagesDoesntMutateRenderPackage #15126

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

saintentropy
Copy link
Contributor

Purpose

The original test had instancing on due to a quirk of the feature flag implementation. This restores the behavior by setting the tessellation parameters to have instancing enabled.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Not applicable. Tests

Reviewers

@reddyashish

FYIs

@QilongTang

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish reddyashish added this to the 3.1 milestone Apr 12, 2024
@QilongTang QilongTang merged commit 1715b0f into DynamoDS:master Apr 14, 2024
22 of 23 checks passed
QilongTang added a commit that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants