Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6769 Improving Dynamo Load Graph II (#15108) #15132

Closed
wants to merge 1 commit into from
Closed

DYN-6769 Improving Dynamo Load Graph II (#15108) #15132

wants to merge 1 commit into from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Testing Regressions on pullRequestValidation job

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Testing Regressions on pullRequestValidation job

Reviewers

FYIs

@RobertGlobant20
DYN-6769 Improving Dynamo Load Graph II (DynamoDS#15108)
e3fa5b3 
* DYN-6769 Improving Dynamo Load Graph

With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.

* DYN-6769 Improving Dynamo Load Graph

With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
@QilongTang
Copy link
Contributor

@sm6srw Do we know for sure if SelfServe would trigger for draft PRs?

@RobertGlobant20
Copy link
Contributor Author

Closing due that I was able to reproduce the two regressions when the tests are executed in parallel (in my local setup both are passing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGlobant20 @QilongTang