Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider localization test #15136

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

reddyashish
Copy link
Contributor

Purpose

This is to fix the slider localization test SliderViewModel_ValueTest_Localized which was marked as failure here

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix slider localization test

Reviewers

@QilongTang @mjkkirschner

@reddyashish reddyashish added this to the 3.1 milestone Apr 16, 2024
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish reddyashish mentioned this pull request Apr 16, 2024
9 tasks
@QilongTang QilongTang merged commit dd7f87d into DynamoDS:master Apr 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants