Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucs turn off with grid #15137

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Apr 16, 2024

Purpose

Small PR to hide/show Axes from HelixWatch3D when the Grid is hidden/shown as well.
Including test.

Before

Dynamo UCS - Before

After

Dynamo UCS

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Hide/show Axes from HelixWatch3D when the Grid is hidden/shown.
Including test.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

Copy link

github-actions bot commented Apr 16, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

- IsAxesVisible is now internal.
- Extra summary to color properties.
- Ensure that aces and grids are visible before Assert visibility in test.
IsAxesVisible removed
@Amoursol
Copy link
Contributor

Awesome, thanks so much @ivaylo-matov 🤩

@QilongTang
Copy link
Contributor

Which Jira task does this belong?

@QilongTang QilongTang added this to the 3.2 milestone Apr 16, 2024
@QilongTang QilongTang marked this pull request as ready for review April 16, 2024 14:26
@ivaylo-matov
Copy link
Contributor Author

@QilongTang , It doesn't have a ticket. This is something Sol and Deyan have been discussing.

@QilongTang QilongTang merged commit 5ef8fa9 into DynamoDS:master Apr 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants